- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Eric Lassauge - 2004-04-21
Last edited by Linus Nielsen Feltzing - 2005-01-13
Opened by Eric Lassauge - 2004-04-21
Last edited by Linus Nielsen Feltzing - 2005-01-13
FS#2154 - New updated version of the euroconverter plugin
New updated version of the euroconverter plugin
(see Request ID [778688] Euroconverter plugin for the
player)
based on latest daily version all in a single patch file :
- typedef and corrected long long type
- LL suffix for long long constants
- included the modified plugin API to add lcd_*_cursor()
(see Requests ID [778684] and [778686] )
rockbox-2.4-euroconv_patch
(4.6 KiB)
Updated for rockbox-daily-20040624.
Deleted all old patch files.
Why is it important to have a typedef for the long long
type? Also, it would be nice if the patch only contained the
actual changes, and not every line in the file. I suspect
that you have different line terminators in your local copy.
Answers to Linus:
- From the gcc info pages:
Double-Word Integers
least 64 bits wide, and as an extension GCC supports them
in C89 mode and in C++.
Simply write `long long int’ for a signed integer, or
`unsigned long long int’ for an unsigned integer.
To make an integer constant of type `long long int’,
add the suffix `LL’ to the integer. To make an
integer constant of type `unsigned long long int’,
add the suffix `ULL’ to the integer.
… that’s why I used my typedef longlong_t because it is
easier to type than “long long int” (recommanded writing by
GCC).
- And now for the patch file format: it is because this patch
was made BEFORE the euroconverter.c file was added in
the apps/plugins directory
…. I’ll include a new modified version based on rockbox-daily-
20040824 maybe tomorrow :→
Here is now the real patch file made with rockbox-daily-
20040824…. It shall contain only the longlong_t trick, and
some LL added for the numeric constants.
Would not be a bad (or hard) idea to make this work on recorder.
-Lee
Updated for rockbox-daily-20041005
Updated for rockbox-2.4