Rockbox

Tasklist

FS#2154 - New updated version of the euroconverter plugin

Attached to Project: Rockbox
Opened by Eric Lassauge (lassauge) - Wednesday, 21 April 2004, 13:59 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Thursday, 13 January 2005, 11:06 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

New updated version of the euroconverter plugin
(see Request ID [778688] Euroconverter plugin for the
player)
based on latest daily version all in a single patch file :
- typedef and corrected long long type
- LL suffix for long long constants
- included the modified plugin API to add lcd_*_cursor()
(see Requests ID [778684] and [778686] )
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 13 January 2005, 11:06 GMT
Reason for closing:  Accepted
Comment by Eric Lassauge (lassauge) - Thursday, 24 June 2004, 12:55 GMT

Updated for rockbox-daily-20040624.
Deleted all old patch files.
Comment by Linus Nielsen Feltzing (linusnielsen) - Sunday, 22 August 2004, 22:18 GMT

Why is it important to have a typedef for the long long
type? Also, it would be nice if the patch only contained the
actual changes, and not every line in the file. I suspect
that you have different line terminators in your local copy.
Comment by Eric Lassauge (lassauge) - Tuesday, 24 August 2004, 16:30 GMT

Answers to Linus:
- From the gcc info pages:

Double-Word Integers
====================

ISO C99 supports data types for integers that are at
least 64 bits wide, and as an extension GCC supports them
in C89 mode and in C++.
Simply write `long long int' for a signed integer, or
`unsigned long long int' for an unsigned integer.
To make an integer constant of type `long long int',
add the suffix `LL' to the integer. To make an
integer constant of type `unsigned long long int',
add the suffix `ULL' to the integer.

... that's why I used my typedef longlong_t because it is
easier to type than "long long int" (recommanded writing by
GCC).

- And now for the patch file format: it is because this patch
was made BEFORE the euroconverter.c file was added in
the apps/plugins directory

.... I'll include a new modified version based on rockbox-daily-
20040824 maybe tomorrow :->
Comment by Eric Lassauge (lassauge) - Wednesday, 25 August 2004, 15:11 GMT

Here is now the real patch file made with rockbox-daily-
20040824.... It shall contain only the longlong_t trick, and
some LL added for the numeric constants.
Comment by Lee Pilgrim (bagawk) - Friday, 01 October 2004, 23:54 GMT

Would not be a bad (or hard) idea to make this work on recorder.

-Lee
Comment by Eric Lassauge (lassauge) - Wednesday, 06 October 2004, 15:42 GMT

Updated for rockbox-daily-20041005
Comment by Eric Lassauge (lassauge) - Monday, 03 January 2005, 12:53 GMT

Updated for rockbox-2.4

Loading...