• Status Closed
  • Percent Complete
  • Task Type Bugs
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by projekt21 - 2004-09-01
Last edited by linusnielsen - 2004-11-05

FS#2316 - "Load last bookmark?" does not wait for input

Device: FMR, CVS-Build: 2004-08-30

When I configure my rockbox to ask “Load last
bookmark?”, it displays the according screen but does
not wait for my input. It continues as if I had
selected “no”. The X11 sim does the same.

If I replace



while (button_get(false));

in bookmark.c everything works again. BTW, there are
still 4 of those while-loops in that file and only one

Closed by  linusnielsen
2004-11-05 07:05
Reason for closing:  Fixed
Project Manager

This was due to a bug in button_clear_queue() that I fixed
earlier today.

Thanks for your quick reply. I am within my office, so I
will check this later, but the X11 sim (with button.c,
v1.49) still does not wait for input. Is this correct?

Project Manager

The X11 simulator doesn’t use button.c, it uses
button-x11.c, so I don’t know what might cause the bookmark
bug there.

I have to apologize for not doing a bit research before
posting. Well, from button-x11.c:

void button_clear_queue(void)

Thanks for your help.

Project Manager

Please note that the empty clear function is not the cause
of this bug. It is supposed to be empty since the X11
simulator doesn’t use a queue, but does raw reads instead.


Available keyboard shortcuts


Task Details

Task Editing