- Status Closed
- Percent Complete
- Task Type Feature Requests
- Category User Interface
- Assigned To No-one
- Operating System All players
- Severity Very Low
- Priority Defer
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Blake - 2005-01-06
Last edited by Daniel Stenberg - 2007-11-12
Opened by Blake - 2005-01-06
Last edited by Daniel Stenberg - 2007-11-12
FS#2429 - show album art in browser/wps
While hovering over a folder or playing a song in a folder
with album art, the album art is displayed.
Closed by Björn Stenberg
2007-11-12 11:33
Reason for closing: Fixed
Additional comments about closing:
2007-11-12 11:33
Reason for closing: Fixed
Additional comments about closing:
Closing all feature requests.
This would be done as a plugin, or possibly shown in the WPS
as #613824 suggests.
I just wanted to add some thoughts on how this might be
accomplished via the wps…
The album art could be buffered at the same time as the
song. While reading the song and tag from disk, the
program could look for: (1) a .bmp with the same name as
the file (without extension), or if that doesn't exist (2)
a .bmp with the same name as the directory. As an example,
the song Kings and Queens from the Aerosmith Greatest Hits
album. Rockbox would look in the same file directory as
the song first for '08 Kings and Queens.bmp' and if that
file didn't exist, it would look for 'Greatest Hits.bmp'.
A new tag could then be added to the wps to show the album
art…maybe something like %xa|x|y| (with %xa indicating
the buffered album art .bmp file should be used). An
additional filename option at the end might be useful as
well, to allow the showing of a generic .bmp when album art
doesn't exist e.g. %xa|x|y|alternatefilename|.
Benefits of this approach:
[1] Relative simplicity K.I.S.S. :)
[2] Creates standard methodology across codecs (since I
believe only id3 tags have the ability to actually store
album art?).
[3] Offers user significant flexibility in determining what
is displayed. Having the filename and folder name options
would avoid restricting users to any specific file
organization technique. Offering an alternative image
option in the wps tag would further enhance that
flexibility.
[4] Gives user control over sizing and placement of image
and uses existing wps .bmp image loading functionality.
I, too, believe there should be flexibility in how the artwork is looked up, so the user can put the artwork filenames wherever he chooses. However, for me at least it would be very useful to have the option of taking the picture from the ID3v2 tags, since this is how I store my album art, for use with, e.g., iTunes.
Currently, at least it appears, Album Art must be on its own line (Like the progress bar) or it won't show at all. it would be nice to be able to use a conditional to determine if AA should be displayed, or even where.
For example (Code that looks like it should hide the Album Art with the hold switch turned on):
# AAHide.bmp is a 100x100 white box
%xl|A|AAHide.bmp|1|1|
%?mh<%xda|%C|1|1|[100|100|]>
This currently does not work, neither does:
%?mh<|%C|1|1|[100|100|]>
To conditionally show Album Art or not.
The 2nd is preferable and cleaner, but the 1st acts like all other images.