Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by pillo79 - 2005-02-26
Last edited by linusnielsen - 2005-05-13

FS#2455 - Fix proportional fonts in text viewer

This patch adds proportional font support to the text
viewer plugin. Word wrapping is done w.r.t. pixel width
and not character count.
I have also added another line mode called “reflow”,
that tries to fit text in the display with uniform word
spacing and paragraph indentation. Reading books on the
Iriver is much better now ;)

   viewer_prop_fonts.patch (17 KiB)
   viewer.rock (17.7 KiB)
Closed by  linusnielsen
2005-05-13 13:33
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Logged In: YES
user_id=259137

Thanks a lot, Luca!

rasher commented on 2005-03-11 00:27

I think there’s a bug with the reflow mode. Sometimes it
would “spill” a character to the preceeding line for me.

Maybe I’ll have a look at the code at some point, but now
you know - you probably have a better chance at fixing this
than me :)

pillo79 commented on 2005-03-11 07:38

You mean fitting a longer string than the maximum width could
allow? Are there any hypens in the line?
Or perhaps you mean placing the first character of a word in a line
and the remaining on the next one?

Could you please submit a text example and specify the font you
used? So I’ll be able to fix it. Thanks!

Anonymous Submitter commented on 2005-03-15 13:38

Can you add a binary .rock for recorder V1? So more people
can test this patch! Thanks!

Joerch

rasher commented on 2005-03-15 23:37

Uh.. I’m now unable to reproduce it.. I’ll keep trying..

rasher commented on 2005-03-15 23:49

No, got it.

Font: proportional.fnt
File: .rockbox/DOCS/CUSTOM_WPS_FORMAT.txt
Mode: Join lines/Reflow lines

Result a bit down:
File location ————- C
Custom WPS files

pillo79 commented on 2005-03-16 08:11

Ok thanks, I’ll work on that.

PS. I’ll try to setup the build environment for Archos;
however, I only own an iRiver, so I can’t test my builds on
Recorders and such. Maybe it’s better if somebody posts his
compiled version.

pillo79 commented on 2005-03-23 23:18

That problem should be fixed now. Let me know if you spot
other quirks.
(No build still for archos, I have to spend some more time
and I can spare really little these days…)

Project Manager
linusnielsen commented on 2005-05-13 13:33

Thanks a lot, Luca!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing