FS#2468 - id3v2 frames with size 0 may cause rockbox to miss tags

Attached to Project: Rockbox
Opened by bryan vandyke (bryan314) - Friday, 11 March 2005, 01:18 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 30 August 2005, 13:01 GMT
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


Rockbox stops processing id3 tags if it encounters an
id3v2 frame with size set to zero, even if there are
valid tag frames after it. Attached is a fix to
continue processing the remaining frames.
   patch (0.6 KiB)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 30 August 2005, 13:01 GMT
Reason for closing:  Accepted
Comment by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 06 July 2005, 18:05 GMT

(Sorry for responding so late)

0-size frames are illegal according to the ID3v2 standard:

"A frame must be at least 1 byte big, excluding the header."

Better tag your files correctly.
Comment by bryan vandyke (bryan314) - Wednesday, 06 July 2005, 20:36 GMT

No problem about the late response, I forgot about the patch
myself. It was off a daily build a while back so it probably
doesn't work anyways. This probably should be closed.

It been a while, but the problem I saw was that when the
rockbox code hits an illegal header it just bails, even if
there are legal headers after that one. My fix just tried
to continue with any valid headers after the bad one.