Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bryan314 - 2005-03-11
Last edited by linusnielsen - 2005-08-30

FS#2468 - id3v2 frames with size 0 may cause rockbox to miss tags

Rockbox stops processing id3 tags if it encounters an
id3v2 frame with size set to zero, even if there are
valid tag frames after it. Attached is a fix to
continue processing the remaining frames.

   patch (0.6 KiB)
Closed by  linusnielsen
2005-08-30 13:01
Reason for closing:  Accepted
Project Manager
linusnielsen commented on 2005-07-06 18:05

(Sorry for responding so late)

0-size frames are illegal according to the ID3v2 standard:

“A frame must be at least 1 byte big, excluding the header.”

Better tag your files correctly.

bryan314 commented on 2005-07-06 20:36

No problem about the late response, I forgot about the patch
myself. It was off a daily build a while back so it probably
doesn’t work anyways. This probably should be closed.

It been a while, but the problem I saw was that when the
rockbox code hits an illegal header it just bails, even if
there are legal headers after that one. My fix just tried
to continue with any valid headers after the bad one.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing