Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rdjackso - 2005-07-05
Last edited by linusnielsen - 2005-07-05

FS#2561 - Seek support for Ogg Vorbis

This patch adds support to Rockbox for the following:
- Seeking within vorbis files
- Vorbis comments
- Mono encodings and encodings at sampling rates other
than 44100Hz.
- Implementation of memchr() (needed for seek support)

Currently the comment support isn’t as clean as I’d
like it. The comments must all exist in the first Ogg
page (which is true 99% of the time). Patch number
1228478 implements better metadata support. Perhaps
this patch could be used with that one?

Also, currently only Ogg files with a single logical
vorbis bitstream are supported. Again, the vast
majority of encodings would fit this category, so this
may not be a problem. If we extended the mp3entry
structure to include the relevant vorbis metadata
(bitstream offsets, vorbis info structs, etc) then we
could easily have support for multiple bitstreams.

Closed by  linusnielsen
2005-07-05 08:44
Reason for closing:  Accepted
Additional comments about closing:  

Logged In: YES
user_id=259137

Thanks a bunch, Ryan!

the memchr.c file goes in firmware/common (but this should
be obvious) :-)

Project Manager

Thanks a bunch, Ryan!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing