Rockbox

Tasklist

FS#2561 - Seek support for Ogg Vorbis

Attached to Project: Rockbox
Opened by Ryan Jackson (rdjackso) - Tuesday, 05 July 2005, 06:36 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 05 July 2005, 08:44 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch adds support to Rockbox for the following:
- Seeking within vorbis files
- Vorbis comments
- Mono encodings and encodings at sampling rates other
than 44100Hz.
- Implementation of memchr() (needed for seek support)

Currently the comment support isn't as clean as I'd
like it. The comments must all exist in the first Ogg
page (which is true 99% of the time). Patch number
1228478 implements better metadata support. Perhaps
this patch could be used with that one?

Also, currently only Ogg files with a single logical
vorbis bitstream are supported. Again, the vast
majority of encodings would fit this category, so this
may not be a problem. If we extended the mp3entry
structure to include the relevant vorbis metadata
(bitstream offsets, vorbis info structs, etc) then we
could easily have support for multiple bitstreams.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 05 July 2005, 08:44 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES
user_id=259137

Thanks a bunch, Ryan!
Comment by Ryan Jackson (rdjackso) - Tuesday, 05 July 2005, 06:39 GMT

the memchr.c file goes in firmware/common (but this should
be obvious) :-)
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 05 July 2005, 08:44 GMT

Thanks a bunch, Ryan!

Loading...