Rockbox

Tasklist

FS#2576 - Enable multiple align tags in wps

Attached to Project: Rockbox
Opened by Markus Braun (malle) - Tuesday, 12 July 2005, 10:39 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 23 August 2005, 10:32 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch enables the usage of multiple alignment tags
iin one line in wps.
The tags need to be in the order left - center - right
to work correctly.
If aligned strings overlap, they are merged.
Test wps files for default font (needed of overlaps):

align.wps:

default is left
%al(l)
%ac(c)
%ar(r)
%al(l)%ac(c)%ar(r)
%t1%al(l);%t1%ac(c);%t1%ar(r)


align_sanity.wps:

%al(l)%ac(c)%ar(r)
%al(lllll)%ac(cccc)%ar(r)
%al(l)%ac(cccc)%ar(rrrrr)
%s%al(lllll)%ac(ccccc)%ar(rrrrr)
%s%al(llllllll)%ar(rrrrrrrr)
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 23 August 2005, 10:32 GMT
Reason for closing:  Accepted
Comment by Anonymous Submitter - Thursday, 04 August 2005, 08:05 GMT

URGENT - this stops my %s working!!!
Comment by Markus Braun (malle) - Thursday, 04 August 2005, 08:38 GMT

Could you be a little more specific please?
What .wps file, what font, what player model?
Comment by Anonymous Submitter - Thursday, 04 August 2005, 08:45 GMT

iRiver H120
Custom Made WPS File:

%x0|hshah.bmp|0|0| %bl
%ar%?mp<Playing|%?mu<Paused|%?mw<F Forward|%?mb<F Back>>>>
%pv

%ac%s%?ia<%ia|%d1>

%ac%s%?it<%it|%fn>

%pb
%al%pc %ar%pt

The %s doesn't work in the middle two lines... I also tried
putting %s before the %ac and still it doesn't work.

I am using xtal-14 font!
Comment by Markus Braun (malle) - Thursday, 04 August 2005, 13:36 GMT

updated patch fixes bug in scrolling lines.
Comment by Markus Braun (malle) - Tuesday, 16 August 2005, 09:45 GMT

Updated for latest CVS version and added more comments
Comment by Jonas Häggqvist (rasher) - Sunday, 21 August 2005, 18:57 GMT

Can anyone tell my why this shouldn't be committed before
the freeze?

Are there any bugs or design problems?

Loading...