FS#2587 - Quickly load configuration files from context menu

Attached to Project: Rockbox
Opened by zeekoe (zeekoe) - Monday, 18 July 2005, 21:50 GMT
Last edited by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 18:00 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


New version of autoloadconfig, but because the resume
screen is gone, this one is in the context menu. It shows
a list of config files at /.rockbox/quickcfg for quickly
changing settings.
Q: Why the context menu?
A: I would rather have it in the F2 or F3 menu, but
patches changing that menu are not allowed. This menu
seemed the best way to quickly access it from WPS.

Q: Why not just browse /.rockbox ?
A: It will show all folders clogging the .rockbox dir, so to
access the config files there has to be scrolled quite a
bit. Also, there may me more config files than needed to
quickly access.
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Wednesday, 17 August 2005, 18:00 GMT
Reason for closing:  Fixed
Comment by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 07:49 GMT

I don't think this menu should be here. The WPS screen
should have options strictly concerning playback in my opinion.

A menu-entry under the "Manage settings" seems more sane.
I'd even personally (and it seems others agree) prefer to
not showing the dirs in .rockbox when browsing .cfg files
and just leaving it at that. It's not much farther away than
going through the WPS context menu (not on iriver at least)
and doesn't add anything to the current interface. Rather
it'd make it simpler.
Comment by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 11:08 GMT

Okay, now you are only shown config files when doing "Browse
.cfg files".

I believe this is fast enough, and adding it to the WPS
context menu where it does not logically belong is not worth
the one or two saved keystroke(s).

I won't close this myself, but I believe it should be closed
as fixed or wontfix, depending on whether it's "good enough".
Comment by zeekoe (zeekoe) - Wednesday, 17 August 2005, 13:00 GMT

Okay, nice solution, thanks. This is indeed better than the WPS menu. "Fixed" is
fine. I also did some reordering of the if/else structure, which saved a few bytes.
Maybe you can look into that, or else I'll make a new patch just for that, if I'm not
too lazy.
Comment by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 18:00 GMT

The if/else structure in filetree.c around line 260-270?

If so, I just changed that with my latest commit which
undoes the previous ones, and achieves the same effect by
adding some parantheses to the if/else.

Could you create another entry for that (or whatever it was
you had changed)? Closing this then.