Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by the_winch - 2005-07-30
Last edited by rasher - 2005-08-21

FS#2604 - Adds wps tags for repeat modes

Adds the following wps tags.

Repeat mode tags:
%mf = repeat off
%ma = repeat all
%mo = repeat one
%ms = repeat shuffle

Example use in .wps file
%?mf<Off|%?ma<All|%?mo<One|%?ms<Shuffle»»

Closed by  rasher
2005-08-21 20:03
Reason for closing:  Accepted

Added tags to get the play mode. Play, pause, fast forward and rewind. I
think with this patch you can use all info in status bar on wps.

Repeat mode tags:
%mf = repeat off, returns f
%ma = repeat all, returns a
%mo = repeat one, returns o
%ms = repeat shuffle, returns s

Playback mode tags
%mp = play, returns p
%mu = pause, returns u
%mw = fastforward, returns w
%mb = fastbackward, returns b

Example use in .wps file
%?mf<off|%?ma<all|%?mo<once|%?ms<shuffle»» %?mp<play|%?mu<pause|%?mw<f forward|%?mb<f back»»

Added tags for hold and remote hold.

%mh = hold, returns h
%mr = remote hold, returns r

Is there any reason why you're not using a single tag like
%rm (repeat mode), returning a, o, s or "not defined"?

I used separate tags so it would work with conditionals since they only test
for a returned value not what the value is.
If I used a single tag you would be stuck with the value returned.

Is this correct or am I missing something?

That's true, but exposes a more generic problem (that you
can't test for the value of a variable).

I can't say I like the way you solved it (I'd much rather a
more generic conditional was implemented), but I understand
the reason.

Anyway, I see that the patch was committed. Marking this as
such.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing