Rockbox

Tasklist

FS#2628 - Battery icon when charging

Attached to Project: Rockbox
Opened by MarkusKaufhold (markuskauf) - Wednesday, 10 August 2005, 16:19 GMT
Last edited by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 08:16 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

On my Iriver H140 i'm display the Battery in the status
bar as numeric, not as an icon.
Now when plug in the charger, the display shows in
certain updates the numbers 0 > 33 > 66 > 100 (or
something like this).
That's somewhat confusing, i would like to have the
Battery icon in the case of charging.

Looking to icons.c, function statusbar_icon_battery
i've remarked that this is already implemented for the
archos recorder (having the define HAVE_CHARGE_CTRL)

By adapting this slightly, also the Irivers will show
the icon when charging with this patch
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Wednesday, 17 August 2005, 08:16 GMT
Reason for closing:  Rejected
Additional comments about closing:  Logged In: YES
user_id=231381

This is the wrong solution to a real problem.

To quote Linus: "it should only do this if it's actually
charging and that detection is still not made in the power
management code"

The effect is that it'll stay there even when the charging
is done.

So whenever the power management code is fixed, this will be
fixed in the right way.

Closing this.
Comment by Jonas Häggqvist (rasher) - Wednesday, 17 August 2005, 08:16 GMT

This is the wrong solution to a real problem.

To quote Linus: "it should only do this if it's actually
charging and that detection is still not made in the power
management code"

The effect is that it'll stay there even when the charging
is done.

So whenever the power management code is fixed, this will be
fixed in the right way.

Closing this.

Loading...