Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 2
  • Private
Attached to Project: Rockbox
Opened by rubberglove - 2005-08-24
Last edited by torne - 2010-03-20

FS#2648 - text viewer button mods

modified button assignment in text viewer slightly so that you have
to HOLD left/right to jump to the beginning/end of the file, instead of
simply pressing… this should avoid accidental jumping around.

Closed by  torne
2010-03-20 21:16
Reason for closing:  Fixed
Additional comments about closing:  

Implemented in r25262

changed button mapping slightly so that (in wide mode) you must press
and hold left/right to jump to the beginning/end of the file, to prevent
accidental jumping around.
also added basic track skipping (previous and next track) for iriver
next=play+select
previous=play+stop

kva commented on 2006-12-29 07:17

It’s good patch for me. Because I sometimes click left/right buttons in narrow mode and it isn’t comfortably to jump to the beginning/end of the file, when I read it. So I try to rebuild my own rockbox version with the patch. And I found some troubles with it. Really I’m not a programmer, C programmer but I corrected errors, I think so, and for me patch works. So if someone wants to use it, I upload it.

kva commented on 2007-07-30 13:24

My last sync.

Has anyone made a patch that allows you to change pages by pressing the NEXT and PREV buttons, instead of scrolling? Sometimes I accidently touch the scroll pad and it’s rather anoying.

So, I was about to commit this but we need your full real name.. please add it in a comment so this can go in.

kva commented on 2008-04-23 18:34

@Jonathan Gordon:
If you mean my real name, it’s Victor Karpunin.
If you mean rubberglove, I don’t know who is he :)

torne commented on 2010-03-20 21:16

I have implemented this differently (it just remaps the buttons before entering the switch statement, which is less code), and it’s committed in r25262.

The track skipping buttons are not implemented as the current version of the text viewer uses more button combinations for bookmarks and other new features, and there isn’t room any more :)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing