Rockbox

Tasklist

FS#2650 - Move credits to a plugin

Attached to Project: Rockbox
Opened by Henrik Backe (hbacke) - Thursday, 25 August 2005, 13:33 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Friday, 02 September 2005, 05:39 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This only to reduce firmware size.

show_logo() is move to misc.c to avoid conflicts with
rockboy.
(if main_menu.h is included in plugin.h ther will be a
conflict with symbols defined in rockboy/menu.c)

This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Friday, 02 September 2005, 05:39 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES
user_id=259137

Thanks, Henrik!
Comment by Henrik Backe (hbacke) - Thursday, 25 August 2005, 13:48 GMT

Patch was incomplete
Comment by Henrik Backe (hbacke) - Thursday, 25 August 2005, 14:18 GMT

Here's a complete patch.
Comment by Henrik Backe (hbacke) - Tuesday, 30 August 2005, 09:33 GMT

Ptach updated (apply with patch -p1 -l)
Comment by Jonas Häggqvist (rasher) - Tuesday, 30 August 2005, 14:02 GMT

This seems like an excellent way to save space. Perhaps
other non-essential parts of Rockbox could also be moved to
plugins? (View ID3 info comes to mind - don't know if the
metadata struct can be reached from plugins though). The
required harddisk spin-up won't pose a problem - certainly
not in the case of credits, probably not in the case of ID3
info either.
Comment by Henrik Backe (hbacke) - Tuesday, 30 August 2005, 14:40 GMT

I also have an updated version of the id3 edit patch (which
moves
edit/browse to a plugin), but I have not done any testing of
the edit part so that patch will have to wait until after
the 2.5 release.
Comment by Jonas Häggqvist (rasher) - Tuesday, 30 August 2005, 15:06 GMT

That's really nice - I tried in vain to bring that patch up
to date a few months ago (the result is in the tracker for
that patch).
Comment by Linus Nielsen Feltzing (linusnielsen) - Friday, 02 September 2005, 05:39 GMT

Thanks, Henrik!

Loading...