Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by hbacke - 2005-08-25
Last edited by linusnielsen - 2005-09-02

FS#2650 - Move credits to a plugin

This only to reduce firmware size.

show_logo() is move to misc.c to avoid conflicts with
rockboy.
(if main_menu.h is included in plugin.h ther will be a
conflict with symbols defined in rockboy/menu.c)

   credits.diff (20.6 KiB)
Closed by  linusnielsen
2005-09-02 05:39
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Logged In: YES
user_id=259137

Thanks, Henrik!

hbacke commented on 2005-08-25 13:48

Patch was incomplete

hbacke commented on 2005-08-25 14:18

Here's a complete patch.

hbacke commented on 2005-08-30 09:33

Ptach updated (apply with patch -p1 -l)

rasher commented on 2005-08-30 14:02

This seems like an excellent way to save space. Perhaps
other non-essential parts of Rockbox could also be moved to
plugins? (View ID3 info comes to mind - don't know if the
metadata struct can be reached from plugins though). The
required harddisk spin-up won't pose a problem - certainly
not in the case of credits, probably not in the case of ID3
info either.

hbacke commented on 2005-08-30 14:40

I also have an updated version of the id3 edit patch (which
moves
edit/browse to a plugin), but I have not done any testing of
the edit part so that patch will have to wait until after
the 2.5 release.

rasher commented on 2005-08-30 15:06

That's really nice - I tried in vain to bring that patch up
to date a few months ago (the result is in the tracker for
that patch).

Project Manager
linusnielsen commented on 2005-09-02 05:39

Thanks, Henrik!

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing