Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rubberglove - 2005-08-28
Last edited by GodEater - 2009-12-24

FS#2653 - added one-click-to-insert functionality in file tree

that’s it. for iriver (i think) click the joystick
(select) to insert the selected
track/directory/playlist to the current playlist (or
create a new one if none) seems to work, use with
caution, enjoy.

Closed by  GodEater
2009-12-24 07:28
Reason for closing:  Rejected
Additional comments about closing:  

This is changing the basic behaviour of the select button in the file viewer, and is never likely to be accepted into the rockbox core.

Anonymous Submitter commented on 2005-11-01 09:47

an update that works with recent builds (2005-10-31) can be
found here: http://forums.rockbox.org/index.php?
action=dlattach;topic=1617.0;id=249

mmohr commented on 2006-03-11 21:08

Here is roolku’s patch updated for today’s CVS.

I hope the patch lasts until it finally find its way into the CVS ;)

mmohr commented on 2006-03-29 08:14

Does no longer work in latest CVS versions - needs some research to make it work again…

mmmm- commented on 2006-08-27 11:44

Here’s an updated version…

mmmm- commented on 2006-08-28 11:01

Fixed remote buttons: record on h1xx remote, navi on h3xx remote

mmmm- commented on 2006-09-18 18:54

This patch isnt for the H3xx alone so as there isn’t an option for iriver h1xx/3xx I’ll put it back to ‘all targets’ It is also as easy as putting the ACTION_TREE_INSERT button def into the appropriate keymap file to extend this functionality to any other target and everybody is invited to do so…

mmmm- commented on 2006-11-11 11:59

Update to latest CVS

goffa commented on 2006-11-11 21:50

Here’s my attempt at making the x5 work. I didn’t touch the remote code as i don’t have a remote. Seems to work fine on my player though.

First patch ever, so watch out. :)

Fixed patch and added all possible playlist options to the menu

Added support for id3 mode

Fixed wrong return values from one_play_click

goffa commented on 2006-12-30 08:14

works on the gigabeat now… may have broken id3 mode

Hi all!
Any chance to get an update for the new changes in the settings.c code?
Thanks a lot, Norbert

goffa commented on 2007-01-28 18:32

I removed the stuff pertaining to settings.c. Player compiled and patch works on my player. Your mileage may vary. Hope it works.

goffa commented on 2007-02-05 04:33

updated for the ipod. I don’t have an ipod, but was able to compile.

goffa commented on 2007-02-06 15:51

found out what the settings.c does. Aparently, it saves changes to settings.c when you write a config. Unfortunately, i don’t know how to update that code at the moment. If anyone could help, it would be greatly appreciated.

Still hoping this can be included in svn

I have fixed this temporarily (for the gigabeat, at least), but will only post a patch when the code settles down (or it is likely to break quickly). If you want it, tell me at #gigabeat, and I’ll give you the updated files.

Made a temporary patch. Changes in the RockBox code have made me change this twice in the last few days, so this may not work when new changes are made.

Hope it works for you.

Well, there was the dreaded slight change in code…broke the patch. Here’s a revision.

This fixes the patch for code changes until 20070304. The click-insert settings are now nested in Settings:General Settings:Playlist. I could put it in the root:Playlist menu, to make it more easily accessible, but it really is a playlist setting and should be in the General settings.

Fixed to cope with changes in playlist_menu.c needs some tidying up (offsets fuzz 1) but I don’t know how to code so I’m surprised I even got it to work :)

ryran commented on 2007-04-02 19:40

I sooooo hope someone can help with this. More issues in playlist_menu… I couldn’t fix it easily.

Don’t know what the problem is that you’re having, Ryan. The patch Gary put up should work. However, here’s what I use, just in case…..

ryran commented on 2007-04-30 20:12

Can someone tell me what the stuff at the end [of the patch file] patching wpslist has to do with this patch?

Ryan - Actually, nothing! I have removed it in the one I use.

Here’s a new one. There’s some fuzz. I’ll take care of that later.

this patch doesnt work with the database. so If you want it commited that needs to be fixed.
Also, there is no chance of commit as long as 1) this isnt ifdefed to only work for targets which have a spare button (i.e not ondio), 2) is changed to replace ACTION_STD_OK when a target has 2 buttons which can do that (iriver, sansa, ipod, you wold use right instead of SELECT), 3) add an enum for the various setting values, if(global_settings.click_insert==1) is nasty. 4) the stuff in playlist_menu.c (the option config) needs to be moved to settings_list.c (copy the CHOICE_SETTING() macro items).

Any chance of having this work with the database?

I’ll look into getting it to work with the database. Should take only a few days.

Here’s the insert patch to make it work with recent code changes. Please tell me if there are any problems.

Hi, I’ve make the modifications for make it work with the database mode.

goffa commented on 2008-05-16 01:36

seems broken again … fails on settings_list.c when i try to patch the current build

It should be ok now.

goffa commented on 2008-05-17 19:35

awesome… thanks

ryran commented on 2008-06-04 01:47

Trivial fix of include for onplay.c – recent menu-reorganization broke it.

I think this patch is a great idea. I have 2 comments:
-This patch causes SELECT not to work in the menus (have to use NEXT to choose menu items). It would be better if it did not affect the menus, only the file browser, in my opinion. I looked at the code a little, but it is beyond me. By the way, I am using a Gigabeat F.
-It would be nice if there were a “replace current playlist” option as well (similar to pressing ENTER while a track is selected from the file browser).

ryran commented on 2008-11-16 04:18

Synched after r18997’s change to settings_list.c

ryran commented on 2008-11-30 05:01

Synched again after new backlight stuff in settings.h…

Hm, can you add E200? That one has a free REC button (only holding REC is used to get to the recording screen).

goffa commented on 2009-01-28 04:32

seems like something broke this patch again. Something in settings.h

I don’t think the patch has a change, seeing it’s basically giving configurabe buttons, which is a NOGO.

I’ve put a similar patch up at  FS#9873  . consider contributing to it please.

goffa commented on 2009-02-28 16:06

My target doesn’t have a record button, but your patch looks nice for those targets that do.

Here’s what my settings.h.rej says:

*
* 429,435

    bool backlight_fade_in;
    bool backlight_fade_out;
#endif

-

#ifdef HAVE_BACKLIGHT_BRIGHTNESS
    int brightness;
#endif

— 429,437 —-

    bool backlight_fade_in;
    bool backlight_fade_out;
#endif

+ int click_insert; /*setting for click behaviour in file tree:
+ 0:insert, 1:insert last,2:queue,
+ 3:queue last,4:insert shuffled*/

#ifdef HAVE_BACKLIGHT_BRIGHTNESS
    int brightness;
#endif

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing