Rockbox

Tasklist

FS#2671 - Iriver: remote hold is on, when remote isn't plugged in.

Attached to Project: Rockbox
Opened by Anonymous Submitter - Thursday, 08 September 2005, 21:17 GMT
Last edited by Daniel Stenberg (bagder) - Wednesday, 28 September 2005, 20:06 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

i found a solution for the remote hold is on, when
remote isn't plugged in.

The remote_button_hold (in firmware/drivers/button.c
line 583 ) function, which gives the status of the
hold-button back, doesn't check if the remote is
plugged in.

To solve this you must change the funktion
from
Code:
bool remote_button_hold(void)
{
return (GPIO1_READ & 0x00100000)?true:false;
}
to
Code:
bool remote_button_hold(void)
{
//check also if the remote is plugged in
//GPIO_READ = 0xDXXXXXXX => not plugged in (X don't
care)
//GPIO_READ = 0x9XXXXXXX => plugged in (X don't care)
return ( (GPIO1_READ & 0x00100000) && !(GPIO_READ &
0x40000000) )?true:false;
}
This task depends upon

Closed by  Daniel Stenberg (bagder)
Wednesday, 28 September 2005, 20:06 GMT
Reason for closing:  Duplicate
Comment by Stephan Wezel (thewolfwillcome) - Friday, 09 September 2005, 06:18 GMT

Oh I forgot to say my real name.

My name is Stephan Wezel
Comment by Jonas Häggqvist (rasher) - Friday, 23 September 2005, 15:04 GMT

The function was used some places to check if the remote
should be read - expecting to get "true" back if it shouldn't.

I had originally applied this patch, but removed it again
because of this.

Adding a remote_connected() function might be the right way
to go, and then calling this in the appropriate places.
Comment by Daniel Stenberg (bagder) - Wednesday, 28 September 2005, 20:06 GMT

replaced by 1303216

Loading...