• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Anonymous Submitter - 2005-09-08
Last edited by bagder - 2005-09-28

FS#2671 - Iriver: remote hold is on, when remote isn't plugged in.

i found a solution for the remote hold is on, when
remote isn’t plugged in.

The remote_button_hold (in firmware/drivers/button.c
line 583 ) function, which gives the status of the
hold-button back, doesn’t check if the remote is
plugged in.

To solve this you must change the funktion
bool remote_button_hold(void)

  return (GPIO1_READ & 0x00100000)?true:false;

bool remote_button_hold(void)

  //check also if the remote is plugged in
  //GPIO_READ = 0xDXXXXXXX => not plugged in (X don't


  //GPIO_READ = 0x9XXXXXXX => plugged in (X don't care)
  return ( (GPIO1_READ & 0x00100000) && !(GPIO_READ &

0×40000000) )?true:false;

Closed by  bagder
2005-09-28 20:06
Reason for closing:  Duplicate

Oh I forgot to say my real name.

My name is Stephan Wezel

The function was used some places to check if the remote
should be read - expecting to get “true” back if it shouldn’t.

I had originally applied this patch, but removed it again
because of this.

Adding a remote_connected() function might be the right way
to go, and then calling this in the appropriate places.

Project Manager

replaced by 1303216


Available keyboard shortcuts


Task Details

Task Editing