- Status Closed
- Percent Complete
- Task Type Patches
- Category
- Assigned To No-one
- Operating System
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#2671 - Iriver: remote hold is on, when remote isn't plugged in.
i found a solution for the remote hold is on, when
remote isn’t plugged in.
The remote_button_hold (in firmware/drivers/button.c
line 583 ) function, which gives the status of the
hold-button back, doesn’t check if the remote is
plugged in.
To solve this you must change the funktion
from
Code:
bool remote_button_hold(void)
{
return (GPIO1_READ & 0x00100000)?true:false;
}
to
Code:
bool remote_button_hold(void)
{
//check also if the remote is plugged in //GPIO_READ = 0xDXXXXXXX => not plugged in (X don't
care)
//GPIO_READ = 0x9XXXXXXX => plugged in (X don't care) return ( (GPIO1_READ & 0x00100000) && !(GPIO_READ &
0×40000000) )?true:false;
}
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Oh I forgot to say my real name.
My name is Stephan Wezel
The function was used some places to check if the remote
should be read - expecting to get “true” back if it shouldn’t.
I had originally applied this patch, but removed it again
because of this.
Adding a remote_connected() function might be the right way
to go, and then calling this in the appropriate places.
replaced by 1303216