Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by thewolfwillcome - 2005-09-12
Last edited by thewolfwillcome - 2005-11-20

FS#2677 - independent visible selection for the statusbar

I have made a little patch to select when the statusbar
will be visible.
With this patch you must change two settings to archive:
Statusbar both, WPS only, Browser only

I have only updated the english.lang file to reflect
the additional setting.

Real Name: Stephan Wezel

PS: Could some of the admins please delete the same
patch report from anonymouse. I had forgotten to login
while summiting the patch.

Closed by  bluebrother
2006-08-26 12:15
Reason for closing:  Out of Date
Additional comments about closing:  

the discussed wps tag has been implemented (as discussed in the comments)

Why the need for two options? Why not just have the option
be a 4-choice one?

Off
Always on
WPS only
Browser only

this is my first one ;) I must decover how a multiple choice
works ;) then i can reduce the two options to one

Fair enough. To be honest, I have no idea myself. Look
around other similar options and see how it works is all the
advice I have to offer.

So here the new patch with an 4-choice option ensteed the 2
seperate one in the first patch

Project Manager

I think a better solution would be to have a WPS tag that
could control the status bar. Then there wouldn't be a need
for an extra option.

Ok i have added the WPS tag "%we"(enable statusbar) and
"%wd"(disable statusbar) to override the global statusbar
setting.

Project Manager

I think the statusbar 4-option setting is unnecessary with
the WPS tag addition. Also, I think the wps_statusbar flag
shouldn't be in the global_settings struct.

Ok Owk now with original statusbar option(on/off) and only
the 2 wps-tags

I leave the other patches for someone who whant the 4-choice
option :)

Project Manager

It would be nice if the patch file only contained the
relevant changes.

so patch cleaned up as far as possible

Project Manager

Why have you changed all status_draw(xxx) calls to

if(global_settings.statusbar)

 status_draw(xxx);

in so many files?

Also, don't use TAB when indenting the code.

I had to change it, because without the change it wouldn't work.

Now i have a other way to ensure that it works.

I hope that this pleases you better

oh in the patch was a failure, now fixed

new version, now it works correctly, when leaving the menu,
which can be accessed by holding the select-button(iriver)
in WPS-Screen

v3: code cleanup

This patch seems to have a bug.

If I have a WPS with no %wd or %we, it defaults to statusbar
off, it seems. It should default to whatever the current
setting is.

i have solved the bug.

oh i forgotten a semicolon :)

updated to the new wps-widget

some minor changes to decrease code-duplications and use a
function instead

and removed the old obsolete patches

some more duplicated code converted into a function

bug fixed: statusbar wasn't shown in wps when %we was given
in wps-file and the statusbar-setting was off

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing