Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Stephan Wezel - 2005-09-12
Last edited by Stephan Wezel - 2005-11-20

FS#2677 - independent visible selection for the statusbar

I have made a little patch to select when the statusbar
will be visible.
With this patch you must change two settings to archive:
Statusbar both, WPS only, Browser only

I have only updated the english.lang file to reflect
the additional setting.

Real Name: Stephan Wezel

PS: Could some of the admins please delete the same
patch report from anonymouse. I had forgotten to login
while summiting the patch.

Closed by  Dominik Riebeling
2006-08-26 12:15
Reason for closing:  Out of Date
Additional comments about closing:  

the discussed wps tag has been implemented (as discussed in the comments)

Jonas Häggqvist commented on 2005-09-12 22:26

Why the need for two options? Why not just have the option
be a 4-choice one?

Off
Always on
WPS only
Browser only

Stephan Wezel commented on 2005-09-12 23:49

this is my first one ;) I must decover how a multiple choice
works ;) then i can reduce the two options to one

Jonas Häggqvist commented on 2005-09-12 23:57

Fair enough. To be honest, I have no idea myself. Look
around other similar options and see how it works is all the
advice I have to offer.

Stephan Wezel commented on 2005-09-13 01:11

So here the new patch with an 4-choice option ensteed the 2
seperate one in the first patch

Admin
Linus Nielsen Feltzing commented on 2005-09-13 04:02

I think a better solution would be to have a WPS tag that
could control the status bar. Then there wouldn't be a need
for an extra option.

Stephan Wezel commented on 2005-09-13 07:58

Ok i have added the WPS tag "%we"(enable statusbar) and
"%wd"(disable statusbar) to override the global statusbar
setting.

Admin
Linus Nielsen Feltzing commented on 2005-09-13 09:27

I think the statusbar 4-option setting is unnecessary with
the WPS tag addition. Also, I think the wps_statusbar flag
shouldn't be in the global_settings struct.

Stephan Wezel commented on 2005-09-13 10:27

Ok Owk now with original statusbar option(on/off) and only
the 2 wps-tags

I leave the other patches for someone who whant the 4-choice
option :)

Admin
Linus Nielsen Feltzing commented on 2005-09-13 10:38

It would be nice if the patch file only contained the
relevant changes.

Stephan Wezel commented on 2005-09-13 11:14

so patch cleaned up as far as possible

Admin
Linus Nielsen Feltzing commented on 2005-09-13 11:31

Why have you changed all status_draw(xxx) calls to

if(global_settings.statusbar)

 status_draw(xxx);

in so many files?

Also, don't use TAB when indenting the code.

Stephan Wezel commented on 2005-09-13 13:07

I had to change it, because without the change it wouldn't work.

Now i have a other way to ensure that it works.

I hope that this pleases you better

Stephan Wezel commented on 2005-09-13 15:33

oh in the patch was a failure, now fixed

Stephan Wezel commented on 2005-09-14 16:23

new version, now it works correctly, when leaving the menu,
which can be accessed by holding the select-button(iriver)
in WPS-Screen

Stephan Wezel commented on 2005-09-17 20:39

v3: code cleanup

Jonas Häggqvist commented on 2005-09-26 14:02

This patch seems to have a bug.

If I have a WPS with no %wd or %we, it defaults to statusbar
off, it seems. It should default to whatever the current
setting is.

Stephan Wezel commented on 2005-09-26 18:45

i have solved the bug.

Stephan Wezel commented on 2005-09-27 12:43

oh i forgotten a semicolon :)

Stephan Wezel commented on 2005-11-18 14:45

updated to the new wps-widget

Stephan Wezel commented on 2005-11-20 16:02

some minor changes to decrease code-duplications and use a
function instead

and removed the old obsolete patches

Stephan Wezel commented on 2005-11-20 16:51

some more duplicated code converted into a function

Stephan Wezel commented on 2005-11-20 17:38

bug fixed: statusbar wasn't shown in wps when %we was given
in wps-file and the statusbar-setting was off

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing