FS#2711 : FM file preset saving/loading

FS#2711 - FM file preset saving/loading

Attached to Project: Rockbox
Opened by Alexander Spyridakis (xaviergr) - Thursday, 06 October 2005, 21:36 GMT
Last edited by Alexander Spyridakis (xaviergr) - Wednesday, 15 February 2006, 08:02 GMT

Task Type	Patches
Category
Status	Closed
Assigned To	Hristo Kovachev (bger)
Operating System
Severity	Low
Priority	Normal
Reported Version
Due in Version	Undecided
Due Date	Undecided
Percent Complete
Votes	0
Private	No

Details

Ok this is the same patch but forgot to login and
couldn't update it.

This is a patch to enable file preset manipulation.
Also there is a new option called Preset mode that
allows to scan presets instead of frequencies.

Fixed a bug if there wasn't a .rockbox/presets folder.
Code policing.

radio.diff (31.8 KiB)

This task depends upon

Closed by Hristo Kovachev (bger)
Sunday, 02 April 2006, 12:25 GMT
Reason for closing: Accepted

Comments (14)
Related Tasks (0/0)

Comment by Alexander Spyridakis (xaviergr) - Friday, 28 October 2005, 01:51 GMT

Another update to make the patch up to date with cvs.
Also I tidied up the code a bit and added a nice icon for
the radio fmr presets.

Comment by Tony Lenox (lenox) - Saturday, 05 November 2005, 16:17 GMT

question: what does "if(radio_get_status() !=
FMRADIO_POWERED)..." code do (I mean what kind of
problem is it trying to solve).

Comment by Anonymous Submitter - Saturday, 05 November 2005, 16:48 GMT

It checks if the radio if it is in stop mode (off) or idle
(playing while in filetree).Then if idle, it will not
initialize the radio in order not to make a 'pop' when the
user enters the radio again.

P.S: On a clean build enter and exit (with the click button)
multiple times, you should hear a 'pop' when you enter the
FM radio again.

Comment by Tony Lenox (lenox) - Sunday, 06 November 2005, 01:08 GMT

I've taken small bits and pieces into my patch. I'll have a look
at presets loading/saving as soon as I commit first batch of
changes.

Comment by Anonymous Submitter - Tuesday, 08 November 2005, 23:06 GMT

A small update of the patch to build cleanly with new CVS
changes.

Comment by Alexander Spyridakis (xaviergr) - Sunday, 04 December 2005, 03:09 GMT

Major Update:

This update will compile with latest major changes in radio.
A whole new different approach is used in this patch.

From now on the saving of an fmr file will occur only on a
manual save or on exit (if there are changes), instead of
saving every time the list is updated.

Removed usage of fmr files outside the radio screen (though
fmr files are still viewable in filetree)

Comment by Alexander Spyridakis (xaviergr) - Friday, 09 December 2005, 01:28 GMT

Update: Code policing and minor fixes.

Comment by Anonymous Submitter - Tuesday, 07 February 2006, 18:47 GMT

Hi!
Would it be possible to update this so it works with the
current CVS?

Thank you!
Roolku

Comment by Anonymous Submitter - Tuesday, 07 February 2006, 20:53 GMT

Ok I will try to update it today or tomorrow.

Comment by Alexander Spyridakis (xaviergr) - Friday, 10 February 2006, 01:44 GMT

Upadated to apply on current CVS.

Comment by Alexander Spyridakis (xaviergr) - Monday, 13 February 2006, 06:06 GMT

Updated with latest CVS changes.

Revert to "Load temporary an fmr file outside of the
designated folder and fire up the radio" approach.

Comment by Alexander Spyridakis (xaviergr) - Wednesday, 15 February 2006, 08:02 GMT

Update: Remove the CVS bug that sometimes the screen is not
updated.

Make the code more bug proof.

Comment by Alexander Spyridakis (xaviergr) - Friday, 24 March 2006, 13:55 GMT

Updated to CVS.

radio.diff (29.3 KiB)

Comment by Alexander Spyridakis (xaviergr) - Sunday, 26 March 2006, 20:16 GMT

Again Updated!

radio.diff (28.7 KiB)

	Tasks related to this task (0)

Duplicate tasks of this task (0)

Rockbox

FS#2711 - FM file preset saving/loading

Details

Loading...