• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category
  • Assigned To
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by xaviergr - 2005-10-06
Last edited by xaviergr - 2006-02-15

FS#2711 - FM file preset saving/loading

Ok this is the same patch but forgot to login and
couldn’t update it.

This is a patch to enable file preset manipulation.
Also there is a new option called Preset mode that
allows to scan presets instead of frequencies.

Fixed a bug if there wasn’t a .rockbox/presets folder.
Code policing.

Closed by  bger
2006-04-02 12:25
Reason for closing:  Accepted

Another update to make the patch up to date with cvs.
Also I tidied up the code a bit and added a nice icon for
the radio fmr presets.

lenox commented on 2005-11-05 16:17

question: what does “if(radio_get_status() !=
FMRADIO_POWERED)…” code do (I mean what kind of
problem is it trying to solve).

Anonymous Submitter commented on 2005-11-05 16:48

It checks if the radio if it is in stop mode (off) or idle
(playing while in filetree).Then if idle, it will not
initialize the radio in order not to make a ‘pop’ when the
user enters the radio again.

P.S: On a clean build enter and exit (with the click button)
multiple times, you should hear a ‘pop’ when you enter the
FM radio again.

lenox commented on 2005-11-06 01:08

I’ve taken small bits and pieces into my patch. I’ll have a look
at presets loading/saving as soon as I commit first batch of

Anonymous Submitter commented on 2005-11-08 23:06

A small update of the patch to build cleanly with new CVS changes.

Major Update:

This update will compile with latest major changes in radio.
A whole new different approach is used in this patch.

From now on the saving of an fmr file will occur only on a
manual save or on exit (if there are changes), instead of
saving every time the list is updated.

Removed usage of fmr files outside the radio screen (though
fmr files are still viewable in filetree)

Update: Code policing and minor fixes.

Anonymous Submitter commented on 2006-02-07 18:47

Would it be possible to update this so it works with the
current CVS?

Thank you!

Anonymous Submitter commented on 2006-02-07 20:53

Ok I will try to update it today or tomorrow.

Upadated to apply on current CVS.

Updated with latest CVS changes.

Revert to “Load temporary an fmr file outside of the
designated folder and fire up the radio” approach.

Update: Remove the CVS bug that sometimes the screen is not

Make the code more bug proof.

Updated to CVS.

Again Updated!


Available keyboard shortcuts


Task Details

Task Editing