Rockbox

Initial style comments:

1) Find yourself a better text editor. The one you are using
saves the files with CR/LF endings, and it saves ISO8859-1
characters as unicode (look in the copyright header, where
the “ö” in “Björn” is changed.

2) Try to limit the lines to 80 columns

3) Can you shorten the “gui_synchronized_” prefix to
something shorter, perhaps “gui_synch_”? Or maybe even
“gui_synclist_”?

4) I’m not sure we can accept how you “hijacked” the
copyright by moving the code to a new file. When we have
migrated the rest of Rockbox to the gui_ interface, we will
remove the old files, and suddenly all gui code originally
written by other people will be copyrighted by you. I know
that you made significant changes to the original code, but
anyway…

5) I had to move the extern declaration of the screens[]
array to after the declaration of the screen struct, or it
wouldn’t compile in the simulator.

6) I think the scrolling margin is too big on the main screen.

Otherwise, I think it looks damn good. This is certainly CVS material to me, but I’ll have a chat with the other devs first.

Thanks for having looked at my work !
about your comments :

1)
I mainly use kate under Linux, but some files were
writter under windows, that could explain the CR/LF
Also, about the encoding, all my systems are using
UTF-8, so things like that may happen sometimes and I
don’t notice them :)

3)
I like clear names which “means”, so that when you
read the code it becomes more clear
if it’s really aproblem, it can of course be shortened /
sed truncated :D

4)
I’m sorry about that, I didn’t intend to “steal” code from
the other, and I thought a lot about what to put in the
headers but I couldn’t find a solution so I asked on IRC
and they told me to simply put my name and nothing
else … (I also wrote the names of the creators of the
code when it was not 100% my work)
Anyway, I was aware of the problem, but for example,
what should I do when the code is taken from differents
files, from different persons ?
Maybe a history of the people who worked on the file in
the header would solve this kind of problems

5)
You’re right !
I wonder why I never even got a single warning about
that :(
anyway I moved it right now :)

6)
It starts at 1/3 from the top / bottom of the screen
I thought it was the current behaviour
I can obviously change it !