FS#2718 - Fast Inc/Dec settings.

Attached to Project: Rockbox
Opened by lshachar (lshachar) - Friday, 14 October 2005, 21:31 GMT
Last edited by lshachar (lshachar) - Saturday, 15 October 2005, 12:32 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Fast increasing / decreasing of sound settings.

this patch binds ON+UP and ON+DOWN to fastly change
settings in sound options menu.
On the first file, there is a new ( static const int
faststeps[] ) defined in firmware/sound.c, to determine
size of every faststep (volume,balance,bass,stereo

On the second file, the value of faststep is always set
to 10, that way some very minimal ram is saved, but you
can't define faststeps size. (say, changing balance
faststep to 15 or 20.)

On Hx00 series, ON+Up/Down used in WPS to change volume
setting by 5.

I don't own other players so i've just ifdefed it a
little not to build for ondio and not to use the WPS
bind for recorers because it's already been used for
pitch. if this will be exepted there should be some

On WPS by higher steps of 5 instead of 1
This task depends upon

Closed by  Daniel Stenberg (bagder)
Thursday, 29 June 2006, 11:01 GMT
Reason for closing:  Rejected
Comment by lshachar (lshachar) - Friday, 14 October 2005, 21:35 GMT

whoops, forget the last line.
Comment by lshachar (lshachar) - Saturday, 15 October 2005, 12:32 GMT

some people agree it's a good idea to move the pitch menu
into sound settings.
Comment by Shachar (Lamed) - Thursday, 29 June 2006, 10:59 GMT
Old... obsolete... forgotten...

Rockbox is holding patches back from 2003-03-04 ...

I think we need a better way to shrink thous lists... what about actually refusing patches!