Rockbox

Tasklist

FS#2719 - Folder skip patch for iRiver's remote

Attached to Project: Rockbox
Opened by Tony Lenox (lenox) - Monday, 17 October 2005, 08:19 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Wednesday, 02 November 2005, 23:09 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Patch includes he following:

- Folder skip using remote SOURCE/BITRATE buttons
on iRiver during playback. Folders are skipped in a
cyclic fashion, i.e. after last folder first one is selected
(and vice versa).
- "Next folder" option in global settings renamed
to "Folder navigation"
- if previous option enabled then it possible to skip to
the next/previous folder just by using next/previous track
navigation.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Wednesday, 02 November 2005, 23:09 GMT
Reason for closing:  Accepted
Comment by Tony Lenox (lenox) - Tuesday, 18 October 2005, 18:34 GMT

Sorry, here the file itself.
(to apply "patch -p0 < folder-skip.patch" from root of RB)
Comment by Tony Lenox (lenox) - Friday, 21 October 2005, 21:00 GMT

new version of the patch working with latest version of CVS
checkout.
Comment by Tony Lenox (lenox) - Sunday, 23 October 2005, 13:17 GMT

v3 - fixed bug in skipping during buffer filling
Comment by Linus Nielsen Feltzing (linusnielsen) - Sunday, 30 October 2005, 10:44 GMT

I like this. A few comments:

1) What about the Archos models?

2) Can you only use the remote to go to the next dir? Could
you find a way to do it using the main device?

3) Don't mix case in the identifiers (isForward)
Comment by Tony Lenox (lenox) - Sunday, 30 October 2005, 11:07 GMT

1 and 2 ) Functions for folder skip are there, so they can be
used by any button combination very easily. I don't know of
any free buttons in WPS that can be used on the main unit
for that and I don't own Archos models to check out button
layout. Do you think double click on left-right joystick button
can be catched as an event?

3) sorry about that - I was using Java notation (I program way
in too many languages at the same time :) )
Comment by Linus Nielsen Feltzing (linusnielsen) - Sunday, 30 October 2005, 11:47 GMT

FYI, the Archos playback code is in firmware/mpeg.c, but it
will be merged with the iriver code some day.

Double click is not that easy, but it has been considered.
I'd personally stay away from double-click, as it believe it
will make the UI harder to use.

We can decide on that after we commit it.
Comment by Tony Lenox (lenox) - Sunday, 30 October 2005, 12:03 GMT

v3a - removed TABs and renamed isForward

Loading...