Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Tony Lenox - 2005-10-17
Last edited by Linus Nielsen Feltzing - 2005-11-02

FS#2719 - Folder skip patch for iRiver's remote

Patch includes he following:

- Folder skip using remote SOURCE/BITRATE buttons
on iRiver during playback. Folders are skipped in a
cyclic fashion, i.e. after last folder first one is selected
(and vice versa).
- “Next folder” option in global settings renamed
to “Folder navigation” - if previous option enabled then it possible to skip to
the next/previous folder just by using next/previous track
navigation.

Closed by  Linus Nielsen Feltzing
2005-11-02 23:09
Reason for closing:  Accepted
Tony Lenox commented on 2005-10-18 18:34

Sorry, here the file itself.
(to apply “patch -p0 < folder-skip.patch” from root of RB)

Tony Lenox commented on 2005-10-21 21:00

new version of the patch working with latest version of CVS
checkout.

Tony Lenox commented on 2005-10-23 13:17

v3 - fixed bug in skipping during buffer filling

Admin
Linus Nielsen Feltzing commented on 2005-10-30 10:44

I like this. A few comments:

1) What about the Archos models?

2) Can you only use the remote to go to the next dir? Could
you find a way to do it using the main device?

3) Don’t mix case in the identifiers (isForward)

Tony Lenox commented on 2005-10-30 11:07

1 and 2 ) Functions for folder skip are there, so they can be
used by any button combination very easily. I don’t know of
any free buttons in WPS that can be used on the main unit
for that and I don’t own Archos models to check out button
layout. Do you think double click on left-right joystick button
can be catched as an event?

3) sorry about that - I was using Java notation (I program way
in too many languages at the same time :) )

Admin
Linus Nielsen Feltzing commented on 2005-10-30 11:47

FYI, the Archos playback code is in firmware/mpeg.c, but it
will be merged with the iriver code some day.

Double click is not that easy, but it has been considered.
I’d personally stay away from double-click, as it believe it
will make the UI harder to use.

We can decide on that after we commit it.

Tony Lenox commented on 2005-10-30 12:03

v3a - removed TABs and renamed isForward

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing