Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lenox - 2005-10-23
Last edited by linusnielsen - 2005-11-18

FS#2725 - fm presets navigation on iRiver - and more!

SOURCE/BITRATE buttons on iRiver’s remote are
assigned next/previous preset functions.

Closed by  linusnielsen
2005-11-18 18:31
Reason for closing:  Accepted
lenox commented on 2005-10-27 20:00

v3 - no longer via remote, but also using main unit. Radio
screen can be in two states (displayed on radio
screen): “Scan mode” when it behaves as it used to
and “Preset mode” when LEFT/RIGHT buttons are preset
navigation. Press and hold joystick to switch between modes.

Additional features:
- automatically detect if preset was played before and
entering Preset Mode on radio startup
- always show status bar on radio screen irrespectively of
global settings

lenox commented on 2005-10-28 20:43

v4 - forgot to migrate SOURCE/BITRATE remote buttons from
the the first versions into v3

Project Manager

I have taken a look at your patch, and it looks good. I have
a few comments:

1) Don’t use TAB characters for indenting (see
docs/CONTRIBUTING)

2) What’s the point with the status bar override?

3) Wouldn’t it be better to use an enum or macros for the
radio mode?

lenox commented on 2005-10-30 10:22

1) sure

2) At the moment code in radio.c already has constant offset
to write stuff on LCD, so space for displaying status bar is
already there - why not use it (its not like we have something
else to display there like on other screens). In the future when
there is more information to show it can be done conditionally
as for other screens, but now there is no reason not to
display it (there were requests about it in the forum).

3) yeah, I can define macros instead of using 0/1

I wanted to do overhaul of button assignments as well… (as
was discussed in the forum)

lenox commented on 2005-10-30 11:21

v5 - implemented (1) and (3) of Linus’ comments

lenox commented on 2005-11-06 00:58

full radio patch including previous plus:

  1. remote support using new GUI API
  2. reassigned buttons for iRiver (including remote)
  3. pause fuctionality for radio
  4. play/pause in status bar for radio
  5. fixed bug when file playback didn’t stop radio for iRiver
  6. general cleanup

todo:

  1. archos support for radio status bar (atm it doesn’t compile)
  2. buttonbar using new GUI API (after initial commit)
  3. archos/ondio button assignments (after initial commit)

although not yet production quality (mostly archos support
needed to be done) - this needs to be looked at so that there
are no surprises when i start commiting stuff.

lenox commented on 2005-11-06 16:26

Made it working with Archos and Ondio as it is now (tested
with simulators) - no new key assignments yet.

lenox commented on 2005-11-13 14:33

new version

Project Manager

Added scan mode for Archos FM recorder.
Long press of ON toggles mode.
Added setting of ADC_GAIN.

Anonymous Submitter commented on 2005-11-18 16:53

Can you please close this as it got committed.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing