Rockbox

Tasklist

FS#2806 - Simplified and uniform volume handling.

Attached to Project: Rockbox
Opened by Jens Arnold (amiconn) - Tuesday, 06 December 2005, 08:26 GMT
Last edited by Jens Arnold (amiconn) - Wednesday, 07 December 2005, 23:10 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

This patch changes the following things in volume handling:

- Removed the various sound scaling options again
- Volume setting in dB on all targets, with the
'natural' range defined by the respective DAC
-78..+18 dB for archos Player
-115..+12 dB for archos Recorders and Ondios
-84.. 0 dB for iriver H1x0 and H3x0
- No artificial volume limiting. On the targets
which need this handling (archos Player, iriver),
the prescaler is used at lower volumes to
avoid clipping like before, but at high volumes,
prescaling is reduced again.

This has the following advantages:

- Less option clutter with less confusion
- More KISS and more uniform code across targets
- 0 dB volume mean line level on all platforms

- Sound settings always represent the actual
values.

It was less-than-optimal before when the volume was
modified in the background, but the sound scaling patch
extended this behind-the-scenes mangling to treble and
bass, even in a possibly unpredictable way when 'adjust
current' was selected.
This task depends upon

Closed by  Jens Arnold (amiconn)
Wednesday, 07 December 2005, 23:10 GMT
Reason for closing:  Accepted
Comment by Jens Arnold (amiconn) - Wednesday, 07 December 2005, 00:29 GMT

- Udated to current CVS
- Changed default values for volume, making sound more
similar and saving one #ifdef in settings.c
- Limited the volume range on archos Recorders and
Ondios to -100..+12 dB, avoiding a 4-char string
in the status bar (-100 dB, being the minimum value,
is replaced by the mute symbol)

Loading...