Rockbox

Tasklist

FS#287 - Backlight on when charging

Attached to Project: Rockbox
Opened by Mark A. Hillebrand (dazzler) - Tuesday, 24 September 2002, 13:43 GMT
Last edited by Daniel Stenberg (bagder) - Tuesday, 01 October 2002, 11:00 GMT
Task Type Patches
Category
Status Closed
Assigned To Daniel Stenberg (bagder)
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Hi,

the attached patch (applying to current CVS) adds
the option "Backlight on when charging" to the
display menu (for recorders).
When set, the backlight is always on when the
charger is inserted.
When off, the usual timeout applies even when the
charger is inserted.

This closes the feature request "[ 603685 ] Constant
backlight with mains connexion".

Implementation detail:

An new language string with the identifier
LANG_BACKLIGHT_ON_WHEN_CHARGING
(default english text: "Backlight on when charging")
has been added.
The global settings contain a new boolean variable
backlight_on_when_charging. The backlight option
has been renamed to
backlight_timeout for clarity.
In the RTC, the backlight_on_when_charging is
stored as the eighth bit
of the backlight byte (0xb), while the
backlight_timeout occupies bit
0..6.

Note: I have already received a note, when I first
posted this patch, regarding the name of that option.
The option applies when the charger is inserted
regardless of whether we are charging or not
charging at the moment. So, the name may be
misinterpreted, if someone has a better suggestions,
please the name in the patch before application to
CVS.

So long,

Mark
This task depends upon

Closed by  Daniel Stenberg (bagder)
Tuesday, 01 October 2002, 11:00 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES
user_id=1110

Comitted and applied. I believe I fixed the simulator build too.
Comment by Daniel Stenberg (bagder) - Monday, 30 September 2002, 19:23 GMT

Howdy. I'm sorry for the slight delay we've had on applying
this patch. :-(

Can you please update it against the current CVS and post an
updated version of the patch? I got so many rejects just now
that I got all dizzy in my head! ;-)

I'll be faster on applying that one, I promise!
Comment by Mark A. Hillebrand (dazzler) - Tuesday, 01 October 2002, 10:29 GMT

Bagder: the patch breaks the simulator compilation, because
the simulator does not link in backlight.o.
One should link that in and provide stubs for the simulator in
backlight.c (same approach as with powermgmt.c).
Could not test, no unit available right now.
Comment by Daniel Stenberg (bagder) - Tuesday, 01 October 2002, 11:00 GMT

Comitted and applied. I believe I fixed the simulator build too.

Loading...