Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To
    bagder
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by dazzler - 2002-09-24
Last edited by bagder - 2002-10-01

FS#287 - Backlight on when charging

Hi,

the attached patch (applying to current CVS) adds 

the option “Backlight on when charging” to the
display menu (for recorders).

When set, the backlight is always on when the 

charger is inserted.

When off, the usual timeout applies even when the 

charger is inserted.

This closes the feature request "[ 603685 ] Constant 

backlight with mains connexion”.

Implementation detail:
An new language string with the identifier 

LANG_BACKLIGHT_ON_WHEN_CHARGING

(default english text: "Backlight on when charging") 

has been added.

The global settings contain a new boolean variable
backlight_on_when_charging. The backlight option 

has been renamed to

backlight_timeout for clarity.
In the RTC, the backlight_on_when_charging is 

stored as the eighth bit

of the backlight byte (0xb), while the 

backlight_timeout occupies bit

0..6.
Note: I have already received a note, when I first 

posted this patch, regarding the name of that option.
The option applies when the charger is inserted
regardless of whether we are charging or not
charging at the moment. So, the name may be
misinterpreted, if someone has a better suggestions,
please the name in the patch before application to
CVS.

So long,
Mark
Closed by  bagder
2002-10-01 11:00
Reason for closing:  Accepted
Additional comments about closing:  

Logged In: YES
user_id=1110

Comitted and applied. I believe I fixed the simulator build too.

Project Manager

Howdy. I’m sorry for the slight delay we’ve had on applying
this patch. :-(

Can you please update it against the current CVS and post an
updated version of the patch? I got so many rejects just now
that I got all dizzy in my head! ;-)

I’ll be faster on applying that one, I promise!

Bagder: the patch breaks the simulator compilation, because
the simulator does not link in backlight.o.
One should link that in and provide stubs for the simulator in
backlight.c (same approach as with powermgmt.c).
Could not test, no unit available right now.

Project Manager

Comitted and applied. I believe I fixed the simulator build too.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing