Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by kobler - 2006-01-05
Last edited by kobler - 2006-01-08

FS#2886 - slow pause because two bad settings_save() in gui_wps_show()

at the start of the loop in gui_wps_show()(while(1)) at
first the audio_paused status is determined. But
because the audio_status() function takes a while
before it returns AUDIO_STATUS_PAUSED (when 'PAUSE' is
pressed and audio_pause() called). The wps_state.paused
is first changed back to false, the settings get saved
again, ata_flush, etc., and all this once more when the
audio_status() finaly returns AUDIO_STATUS_PAUSED.
This behaviour only shows up, when Fading on Stop/pause
is switched of and maybe without a peak meter.
The wrong assumtion probably is, that, when
audio_pause() ist called, audio_status() imediately
returns AUDIO_STATUS_PAUSED. This is not true as far as
I can see.

When moving the check for external pause status change
*after* the wait(for key) it works better! The
unnecessary settings_save, etc. only happen at the
first 'pause' after starting to play. Then it works. If
you want to have a patch, I'll try to isolate my 90% fix.

   slowpause.patch (1.9 KiB)
Closed by  christi-s
2006-03-19 13:01
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Please re-open if this is still a problem.

Project Manager
linusnielsen commented on 2006-01-06 09:50

It would surely be nice if you created a patch. Thanks.

kobler commented on 2006-01-06 10:37

The pause sync check is split into a part before the loop
and one after the timeout/wait_for_key. With this the
chances that audio_status() returns the correct pause state
is much better, cause it is not called immediately after
audio_pause().
I didn't check in detail with fade(). Probably the problem
exist there, too.

kobler commented on 2006-01-08 10:46

now the patch, really 8-/

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing