• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by petur - 2006-01-11
Last edited by petur - 2006-02-08

FS#2904 - iRiver recording gain (upd 2006-02-07)

* corrects settings naming where adc_gain was used but
contained decimator gain (affects several files!)

* changes the way stereo channels are changed: puts a
selector on both lines to allow both channels to be

* analog and digital gain merged into one big gain
range (always best quality) with indication if you're
changing analog or digital gain

NOTE: had trouble creating patch file, let me know if
there's a problem with it.

Closed by  petur
2006-02-08 14:33
Reason for closing:  Accepted
petur commented on 2006-01-12 23:01

patch file should be OK now

petur commented on 2006-01-13 20:42

yet another try to create a patch…

petur commented on 2006-01-15 19:58

corrects line selector bug in case of icon cursor
corrects frequency display bug
verified patch ;)

petur commented on 2006-01-15 20:55

inserts blank line between gain and frequency indicator
removes quality setting

petur commented on 2006-01-16 23:21

removed a compiler warning, verified against latest CVS

petur commented on 2006-01-23 22:40


patch updated… developer output is still i the code in

- always maximum analog gain (no more negative digital gain
when analog is positive)
- combined L/R gain now also for the other targets
- minor fixes
- tidied the code more
- made compatible with latest CVS version

petur commented on 2006-01-25 23:32

patch updated for CVS version 2006-01-26

petur commented on 2006-02-02 23:11

new version
- digital gain for mic and line-in are stored separately in
the settings
- adapted to lates CVS state

already did:
- combine analog and digital gain in one smooth range for
Hxxx players (by Mmmm)
- combined left/right gain changing by selecting both
channels first

petur commented on 2006-02-03 21:57

simplified the calculations

petur commented on 2006-02-04 08:59

oops - C++ style comment removed
adapted to latest CVS state (AGAIN)

petur commented on 2006-02-05 09:57

adapted to latest CVS state

petur commented on 2006-02-05 10:48

- fixed warning on Archos
- removed extra space in gain string

petur commented on 2006-02-06 20:07

adapted to latest CVS

recap of what this patch does:
* all platforms:
- corrects gain display bug (CVS version displays negative
gains as -1.-5 where it should be -1.5)
- allows combined setting of stereo gain without an extra
line on the display: both settings get highlighted. This is
in preparation of remote control.
* iRiver H1xx and H3xx specific:
- correctly named the decimator variables, they were
called 'gain'
- splitted decimator gain settings for mic and line-in so
that they are saved separately
- added combined analog and decimator gain setting giving a
smooth gain range with the best analog/decimator gain

With a lot of help by Mmmm!


Available keyboard shortcuts


Task Details

Task Editing