Rockbox

Tasklist

FS#2904 - iRiver recording gain (upd 2006-02-07)

Attached to Project: Rockbox
Opened by Peter D'Hoye (petur) - Wednesday, 11 January 2006, 23:40 GMT
Last edited by Peter D'Hoye (petur) - Wednesday, 08 February 2006, 14:33 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

* corrects settings naming where adc_gain was used but
contained decimator gain (affects several files!)

* changes the way stereo channels are changed: puts a
selector on both lines to allow both channels to be
changed

* analog and digital gain merged into one big gain
range (always best quality) with indication if you're
changing analog or digital gain

NOTE: had trouble creating patch file, let me know if
there's a problem with it.
This task depends upon

Closed by  Peter D'Hoye (petur)
Wednesday, 08 February 2006, 14:33 GMT
Reason for closing:  Accepted
Comment by Peter D'Hoye (petur) - Thursday, 12 January 2006, 23:01 GMT

patch file should be OK now
Comment by Peter D'Hoye (petur) - Friday, 13 January 2006, 20:42 GMT

yet another try to create a patch...
Comment by Peter D'Hoye (petur) - Sunday, 15 January 2006, 19:58 GMT

corrects line selector bug in case of icon cursor
corrects frequency display bug
verified patch ;)
Comment by Peter D'Hoye (petur) - Sunday, 15 January 2006, 20:55 GMT

inserts blank line between gain and frequency indicator
removes quality setting
Comment by Peter D'Hoye (petur) - Monday, 16 January 2006, 23:21 GMT

removed a compiler warning, verified against latest CVS
version
Comment by Peter D'Hoye (petur) - Monday, 23 January 2006, 22:40 GMT

BASED ON MODIFIED PATCH FROM MMMM

patch updated... developer output is still i the code in
comment...

changed:
- always maximum analog gain (no more negative digital gain
when analog is positive)
- combined L/R gain now also for the other targets
- minor fixes
- tidied the code more
- made compatible with latest CVS version
Comment by Peter D'Hoye (petur) - Wednesday, 25 January 2006, 23:32 GMT

patch updated for CVS version 2006-01-26
Comment by Peter D'Hoye (petur) - Thursday, 02 February 2006, 23:11 GMT

new version
- digital gain for mic and line-in are stored separately in
the settings
- adapted to lates CVS state

already did:
- combine analog and digital gain in one smooth range for
Hxxx players (by Mmmm)
- combined left/right gain changing by selecting both
channels first

Comment by Peter D'Hoye (petur) - Friday, 03 February 2006, 21:57 GMT

simplified the calculations
Comment by Peter D'Hoye (petur) - Saturday, 04 February 2006, 08:59 GMT

oops - C++ style comment removed
adapted to latest CVS state (AGAIN)
Comment by Peter D'Hoye (petur) - Sunday, 05 February 2006, 09:57 GMT

adapted to latest CVS state
Comment by Peter D'Hoye (petur) - Sunday, 05 February 2006, 10:48 GMT

- fixed warning on Archos
- removed extra space in gain string
Comment by Peter D'Hoye (petur) - Monday, 06 February 2006, 20:07 GMT

adapted to latest CVS

recap of what this patch does:
*** all platforms:
- corrects gain display bug (CVS version displays negative
gains as -1.-5 where it should be -1.5)
- allows combined setting of stereo gain without an extra
line on the display: both settings get highlighted. This is
in preparation of remote control.

*** iRiver H1xx and H3xx specific:
- correctly named the decimator variables, they were
called 'gain'
- splitted decimator gain settings for mic and line-in so
that they are saved separately
- added combined analog and decimator gain setting giving a
smooth gain range with the best analog/decimator gain
combination

With a lot of help by Mmmm!

Loading...