Rockbox

Tasklist

FS#2908 - H300 brightness bugfix

Attached to Project: Rockbox
Opened by Peter D'Hoye (petur) - Thursday, 12 January 2006, 21:26 GMT
Last edited by Peter D'Hoye (petur) - Thursday, 19 January 2006, 14:21 GMT
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Operating System
Severity Medium
Priority High
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

now correctly disables IRQs before I2C bitbanging -
solves the problem of incorrect brightness at
startup/reboot
This task depends upon

Closed by  Peter D'Hoye (petur)
Thursday, 19 January 2006, 14:21 GMT
Reason for closing:  Accepted
Comment by Peter D'Hoye (petur) - Friday, 13 January 2006, 20:32 GMT

removed the dedicated function in pcf50606 and tried to
make a better patch.
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 16 January 2006, 12:13 GMT

Looks good. One thing though, you still don't follow the
directives in docs/CONTRIBUTING:

"Variables and function names should be all lower case"
Comment by Peter D'Hoye (petur) - Monday, 16 January 2006, 23:16 GMT

code adapted to coding rules and current state of CVS

Loading...