- Status Closed
- Percent Complete
- Task Type Patches
- Category Music playback
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority High
- Reported Version Daily build (which?)
- Due in Version Version 3.0
-
Due Date
Undecided
- Votes
- Private
FS#2917 - FIX: retrieval of total sample count in get_vorbis_metadata
Repost as the attachment was missed/lost.
get_vorbis_metadata may return a too small sample count
(depending on the ogg file beeing analysed).
The reasons are:
- the last five bytes of a data chunk in buffer are
always discarded if no "OggS" mark was found in buffer
so far. Hence the beginning of a header in these five
bytes is lost sight of.
- Moving an OggS mark to start of buffer (after it was
found in the last 17 bytes of a data chunk) doesn't
work like expected (out of boundary read, buffer
garbling).
- If a header was found in buffer it is not checked if
there are other ones. OK, as the buffer is very small
this is unlikely to happen.
A patch is hopefully attached this time.
metadata1.diff
(2 KiB)
Closed by learman
2006-05-01 13:58
Reason for closing: Accepted
Additional comments about closing:
2006-05-01 13:58
Reason for closing: Accepted
Additional comments about closing:
Patch committed, thanks!
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Would this by chance lead to crashing on certain not quite right oggs?