Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Music playback
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority High
  • Reported Version Daily build (which?)
  • Due in Version Version 3.0
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by gdirschl - 2006-01-14
Last edited by zagor - 2006-03-24

FS#2917 - FIX: retrieval of total sample count in get_vorbis_metadata

Repost as the attachment was missed/lost.

get_vorbis_metadata may return a too small sample count
(depending on the ogg file beeing analysed).
The reasons are:
- the last five bytes of a data chunk in buffer are
always discarded if no "OggS" mark was found in buffer
so far. Hence the beginning of a header in these five
bytes is lost sight of.
- Moving an OggS mark to start of buffer (after it was
found in the last 17 bytes of a data chunk) doesn't
work like expected (out of boundary read, buffer
garbling).
- If a header was found in buffer it is not checked if
there are other ones. OK, as the buffer is very small
this is unlikely to happen.

A patch is hopefully attached this time.

Closed by  learman
2006-05-01 13:58
Reason for closing:  Accepted
Additional comments about closing:  

Patch committed, thanks!

Would this by chance lead to crashing on certain not quite right oggs?

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing