• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by rotator - 2006-02-02
Last edited by linusnielsen - 2006-02-02

FS#2978 - Fix splash() color problems

There are two problems with the current splash

1) splash() alters the background color and sets it to
LCD_DEFAULT_BG when finished. This overrides any
custom set background color (set in a plugin for
instance) and forces the programmer to explicitly reset
the background color after every call to splash().

2) splash() is hard coded to use LCD_LIGHTGRAY for the
background color (for visibility reasons I assume) but
still uses the current foreground color. If the
foreground color is a light color, the splash is
difficult or impossible to read.

This patch fixes these problems by hard coding the
splash foreground color to LCD_BLACK, ensuring that the
splash is always dark text on a light background. In
addition it saves then restores the original foreground
and background colors.

Comments would be appreciated.

Closed by  linusnielsen
2006-02-02 22:01
Reason for closing:  Accepted

Fixed warnings


Available keyboard shortcuts


Task Details

Task Editing