Rockbox

Tasklist

FS#2978 - Fix splash() color problems

Attached to Project: Rockbox
Opened by Adam Boot (rotator) - Thursday, 02 February 2006, 19:35 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Thursday, 02 February 2006, 22:01 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

There are two problems with the current splash
implementation:

1) splash() alters the background color and sets it to
LCD_DEFAULT_BG when finished. This overrides any
custom set background color (set in a plugin for
instance) and forces the programmer to explicitly reset
the background color after every call to splash().

2) splash() is hard coded to use LCD_LIGHTGRAY for the
background color (for visibility reasons I assume) but
still uses the current foreground color. If the
foreground color is a light color, the splash is
difficult or impossible to read.


This patch fixes these problems by hard coding the
splash foreground color to LCD_BLACK, ensuring that the
splash is always dark text on a light background. In
addition it saves then restores the original foreground
and background colors.

Comments would be appreciated.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 02 February 2006, 22:01 GMT
Reason for closing:  Accepted
Comment by Adam Boot (rotator) - Thursday, 02 February 2006, 21:50 GMT

Fixed warnings

Loading...