Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by tfact - 2006-02-07
Last edited by mmohr - 2006-04-02

FS#2994 - Scrolling Margins for new CVS

The patch adds the possibility to restrict the width of a (scrolling) line.
It enables you to position the scroll text inside the line and give him a
starting and ending position.
It extents the %s WPS tag to the following:
%s%m|x1|x2|
where x1 is the x-position where the line text starts and x2 is the
ending x-position of the scroll text (actually, when I look at the
code, it should also work for nonscrolling text…)
Only one margin is allowed per line.

BTW, I assume this patch will never find it’s way into the CVS.
The devs plan something more generous, called “viewports”.
The plan is to include it in v3.1 - regarding the release plan it
will be somewhere between now and (latest) November 2006.

Until the viewports find it’s way into CVS this patch here seems
to be useful for a lot of people… (and it is also the base for other patches)

You may find the patch compatible to the current CVS always
at the end of the comments to this task…

Closed by  paprica
2006-04-03 12:36
Reason for closing:  Duplicate
Additional comments about closing:  

we are returning to the orginal task
http://www.rockbox.org/tr acker/task/2954

mmohr commented on 2006-03-11 20:58

Here is the patch for today’s CVS (20060311)

Hopefully the changed patch will work until it finally find it’s way into the CVS ;)

mmohr commented on 2006-03-24 22:26

Here is another sync to today’s CVS (2006-03-24)

Although it seems it’ll never find it’s way into CVS

scroll-margins_20060324.patch applied to the cvs download I have from 2006-03-24_22:02 However, it does not build.

CC debug_menu.c
debug_menu.c: In function `dbg_ports’:
debug_menu.c:1042: error: too few arguments to function `lcd_setmargins’ make[1]: * [/home/rob/ipod-linux/rockbox/cvs/src/rockbox-bleeding/build/apps/debug_menu.o] Error 1
make:
* [all] Error 2

I looked at your patch, and changed line 1042 to be → lcd_setmargins(0, LCD_WIDTH, 0);

And it at least builds now. :-)

Hope this gets into CVS soon!

It built just fine, and my iPod 5G runs ok. I don’t know, however, what this patch is supposed to do, so I can’t tell you if I have tested exactly this code.

This patch will never get into CVS, so the developers. They want to make something like containers which can get positioned at any position on the display. Sorry, I don’t know the name of it anymore.
But as long there is no alternative for the scroll margins patch I will use it.

mmohr commented on 2006-03-25 23:48

Rob, you were right. It seems I missed that line - and a few others ;)
I added an updated patch which also fixes some small bugs I found.

I also updated the description of the patch above…

And yes, I also doubt it will ever be put into CVS.
The devs plan something more generous, called “viewports”.
The plan is to include it in v3.1 - regarding the release plan it’ll
be (latest) November 2006.

So until then this patch here is needed for a lot of people… (and is also the base for other patches)

Synched with current CVS (2006-03-29)

Fixed a small problem in the previous patch

mmohr commented on 2006-04-02 18:00

Here is another sync to the current CVS (2006-04-02)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing