Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by paprica - 2006-02-07
Last edited by paprica - 2006-02-10

FS#2996 - Bitmap ScrollBar

i add a tag for the wps
%P|filname.bmp|

if the tag is use, the progressbar will be a bitmap…

sample video:
http://plugbox.rockbox-lounge.de/wps/ipod-wps-h300.avi

i add also the wps with the new tag..

Closed by  paprica
2006-02-10 14:32
Reason for closing:  Accepted

returns an error on gwps-common.c when patching against
latest CVS

Here's the contents of the gwps-common.c.rej file:

*
* 1529,1540

#define PROGRESS_BAR_HEIGHT gwps->data-

>progress_height /* this should probably be defined
elsewhere; config-*.h perhaps? */

                if (!gwps->data->progress_end) 
                            gwps->data->progress_end=gwps-

>display→width;
- gui_scrollbar_draw(display, gwps→data-
>progress_start, sby,
- gwps→data-
>progress_end-gwps→data→progress_start,
- PROGRESS_BAR_HEIGHT,
- state→id3→length?
state→id3→length:1, 0,
- state→id3→length?
state→id3→elapsed + state→ff_rewind_count:0,
- HORIZONTAL);

#ifdef AB_REPEAT_ENABLE
                if ( ab_repeat_mode_enabled() )
                    ab_draw_markers(display, state->id3-

>length, 0, sby,
— 1584,1605 —-

#define PROGRESS_BAR_HEIGHT gwps->data-

>progress_height /* this should probably be defined
elsewhere; config-*.h perhaps? */

                if (!gwps->data->progress_end) 
                            gwps->data->progress_end=gwps-

>display→width;
+
+ if (gwps→data-
>progressbar.have_picture_pb)
+ gui_pic_scrollbar_draw(display, gwps-
>data→progressbar.bm,
+ gwps→data-
>progress_start, sby,
+ gwps→data-
>progress_end-gwps→data→progress_start,
+ gwps→data-
>progressbar.bm.height,
+ state→id3-
>length?state→id3→length:1, 0,
+ state→id3-
>length?state→id3→elapsed + state→ff_rewind_count:0,
+ HORIZONTAL);
+ else
+ gui_scrollbar_draw(display, gwps-
>data→progress_start, sby,
+ gwps→data-
>progress_end-gwps→data→progress_start,
+
PROGRESS_BAR_HEIGHT,
+ state→id3-
>length?state→id3→length:1, 0,
+ state→id3-
>length?state→id3→elapsed + state→ff_rewind_count:0,
+ HORIZONTAL);

#ifdef AB_REPEAT_ENABLE
                if ( ab_repeat_mode_enabled() )
                    ab_draw_markers(display, state->id3-

>length, 0, sby,

I synched this patch with CVS of 2006.02.08. Get it here :
http://nicolas.pennequin.free.fr/bitmap-scrollbar_20060208.diff

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing