Rockbox

Tasklist

FS#2996 - Bitmap ScrollBar

Attached to Project: Rockbox
Opened by Ben Basha (paprica) - Tuesday, 07 February 2006, 18:10 GMT
Last edited by Ben Basha (paprica) - Friday, 10 February 2006, 14:32 GMT
Task Type Patches
Category
Status Closed
Assigned To No-one
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details


i add a tag for the wps
%P|filname.bmp|

if the tag is use, the progressbar will be a bitmap...

sample video:
http://plugbox.rockbox-lounge.de/wps/ipod-wps-h300.avi

i add also the wps with the new tag..
This task depends upon

Closed by  Ben Basha (paprica)
Friday, 10 February 2006, 14:32 GMT
Reason for closing:  Accepted
Comment by needleboy (needleboy) - Wednesday, 08 February 2006, 08:09 GMT

returns an error on gwps-common.c when patching against
latest CVS...
Comment by needleboy (needleboy) - Wednesday, 08 February 2006, 08:51 GMT

Here's the contents of the gwps-common.c.rej file:

***************
*** 1529,1540 ****
#define PROGRESS_BAR_HEIGHT gwps->data-
>progress_height /* this should probably be defined
elsewhere; config-*.h perhaps? */
if (!gwps->data->progress_end)
gwps->data->progress_end=gwps-
>display->width;
- gui_scrollbar_draw(display, gwps->data-
>progress_start, sby,
- gwps->data-
>progress_end-gwps->data->progress_start,
- PROGRESS_BAR_HEIGHT,
- state->id3->length?
state->id3->length:1, 0,
- state->id3->length?
state->id3->elapsed + state->ff_rewind_count:0,
- HORIZONTAL);
#ifdef AB_REPEAT_ENABLE
if ( ab_repeat_mode_enabled() )
ab_draw_markers(display, state->id3-
>length, 0, sby,
--- 1584,1605 ----
#define PROGRESS_BAR_HEIGHT gwps->data-
>progress_height /* this should probably be defined
elsewhere; config-*.h perhaps? */
if (!gwps->data->progress_end)
gwps->data->progress_end=gwps-
>display->width;
+
+ if (gwps->data-
>progressbar.have_picture_pb)
+ gui_pic_scrollbar_draw(display, gwps-
>data->progressbar.bm,
+ gwps->data-
>progress_start, sby,
+ gwps->data-
>progress_end-gwps->data->progress_start,
+ gwps->data-
>progressbar.bm.height,
+ state->id3-
>length?state->id3->length:1, 0,
+ state->id3-
>length?state->id3->elapsed + state->ff_rewind_count:0,
+ HORIZONTAL);
+ else
+ gui_scrollbar_draw(display, gwps-
>data->progress_start, sby,
+ gwps->data-
>progress_end-gwps->data->progress_start,
+
PROGRESS_BAR_HEIGHT,
+ state->id3-
>length?state->id3->length:1, 0,
+ state->id3-
>length?state->id3->elapsed + state->ff_rewind_count:0,
+ HORIZONTAL);
#ifdef AB_REPEAT_ENABLE
if ( ab_repeat_mode_enabled() )
ab_draw_markers(display, state->id3-
>length, 0, sby,
Comment by Nicolas Pennequin (nicolas_p) - Thursday, 09 February 2006, 15:49 GMT

I synched this patch with CVS of 2006.02.08. Get it here :
http://nicolas.pennequin.free.fr/bitmap-scrollbar_20060208.diff

Loading...