FS#3003 - Crash with old ogg/vorbis files

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Thursday, 09 February 2006, 17:09 GMT
Last edited by Christi Scarborough (christi-s) - Sunday, 19 March 2006, 15:45 GMT
Task Type Bugs
Category Codecs
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Immediate
Reported Version
Due in Version Version 3.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


(Running on iriver h120)

I have a file encoded with a pre-1.0 version
(Xiphophorus libVorbis I 20000508), that freezes
Rockbox when I attempt to play it. The harddrive light
stays on, and the player is unresponsive.

FWIW, the iriver firmware won't play it either, but
skips it. Winamp does play it though, so it's not a
broken file as such, just old.

I'm not adding this to #1411650 since the symptoms are
different (lock-up vs. not playing). Plus, this problem
is probably related to the file being old, and #1411650
is not.

I'll email the file if anyone wants to test.
This task depends upon

Closed by  Magnus Holmgren (learman)
Wednesday, 05 April 2006, 14:04 GMT
Reason for closing:  Fixed
Comment by Magnus Holmgren (learman) - Wednesday, 05 April 2006, 09:52 GMT
Ah, the old "out of memory" problem. :) Certain Vorbis files need a bit of memory to decode, and in this case, Rockbox soon runs out of memory. Introducing a real malloc & friends might help, but the malloc buffer size would need to be increased, to cope with overhead and memory fragmentation (peak memory usage for this file is within the current size though). Making Tremor exit gracefully would be nice, but I'm not sure how much work that would require.

Anyway, I'll see if I can improve things a bit...
Comment by Magnus Holmgren (learman) - Wednesday, 05 April 2006, 14:03 GMT
Turned out it was quite easy to fix playback of this particular file at least.