Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 1
  • Private
Attached to Project: Rockbox
Opened by Anonymous Submitter - 2006-02-17
Last edited by bluebrother - 2011-06-04

FS#3037 - Gif Viewer

i’ve made a gif viewer called viewbox
it would be great if someone will be nice enough
to go over it and fix it for the H300 target cause
it works only on the h300 sim and apperantly on the
ipod too…

Closed by  bluebrother
2011-06-04 20:43
Reason for closing:  Out of Date
Additional comments about closing:  

image viewers are now consolidated in the imageviewer plugin

I like this. It could use some wotk, but it’s a very good feature Rockbox should have had for a while.

Ill try it out and see if it still works later, then if not ill try to get it up to speed, and include some new keymaps, too.

I’m looking for an c written gif-lib to port, or can any coredev have a look?
Currently I did only fixed errors and warnings, removed unnecessary code and renamed it to gifview.

   gifview.zip (118.6 KiB)

Now in my holidays I hope i get it to work.

(application/octet-stream)    gifview.c (19.9 KiB)

is there any progress?

No, sorry I’m learning for my exams :(
You can work with the latest code above.

I think even though you think that the BMP viewer is useless because rockpaint opens BMP
already, I think we need a more developed viewer for BMP (zoom and stuff)
and leave the editing for rockpaint through the “Open With…” option…

in the end it’s the same code
which i’ve written… (i’ve written both rockpaint and viewbox)

I just thought there is no need for a third bmpviewer and removed the bmpviewer from the gifviewer-code, because there are already two.

where do the .c files go?

Paul: Patches are modifications to the source code. If you wish to test them, you must build your own binary using a compiler. Please research this in the wiki and elsewhere.

Can someone update this file?

jeffp commented on 2010-03-31 17:22

i second Gman’s comment. we need a gif viewer!

Heh, Only took one year for someone to agree with me.

Akur commented on 2010-07-19 19:16

This compiles and runs with svn revision 27497.

Tested in Sansa Fuze V2 simulator.
Same file as above but synced..

Akur commented on 2010-07-20 12:41

A few things that I forgot to warn…

The patch above was tested only with very simple gif. Do NOT try animated gifs as it will not work. Besides this has no support for greyscale players.
You use it on a simulator only.

This patch needs a lot of new keymaps to work on new targets, and should probably be incorporated into the new universal image viewer
plugin that we have in SVN now. It’s a great plugin, otherwise.

I hope one day it will also support animated .gif’s as well =P there are just so many it shouldn’t be an omission ^^

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing