Rockbox

Tasklist

FS#3040 - Fix invalid button prompts for H300 (yes/no and bookmark)

Attached to Project: Rockbox
Opened by Sean Stasica (sazbot) - Saturday, 18 February 2006, 04:08 GMT
Last edited by Jonas Häggqvist (rasher) - Tuesday, 28 February 2006, 14:22 GMT
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The following language prompts are incorrect for the
H300 series
LANG_BOOKMARK_SELECT_PLAY eng: "PLAY = Select"
LANG_BOOKMARK_SELECT_DELETE eng: "ON+Play = Delete"
LANG_CONFIRM_WITH_PLAY_RECORDER eng: "PLAY = Yes"

Three new prompts were added to replace the PLAY button
text with NAVI for that model.

LANG_BOOKMARK_SELECT_NAVI eng: "NAVI = Resume"
LANG_BOOKMARK_SELECT_DELETE_NAVI eng: "PLAY+NAVI = Delete"
LANG_CONFIRM_WITH_NAVI eng: "NAVI = Yes"

For simplicity I only provided the english language
updates. It's easy enough to update most language
files to include the new tokens (especially since I
believe all worldwide models have the letters "NAVI" on
the button). However most language files are many
language tokens behind the english version as it is,
and I was unsure of the logistics of getting them all
up to speed in order to add these new ones.
This task depends upon

Closed by  Hristo Kovachev (bger)
Monday, 27 March 2006, 06:53 GMT
Reason for closing:  Wont Fix
Additional comments about closing:  Currently you can\'t just change these strings, because they are used on *all* targets, on which Rockbox runs. They are correct for the Archos players. The problem will be solved by the lang v2, which will allow different language strings per target. This should be done before 3.0 release
Comment by needleboy (needleboy) - Tuesday, 28 February 2006, 08:53 GMT
The bookmark.h and yesno.h diffs get errors on patching.
Comment by Jonas Häggqvist (rasher) - Tuesday, 28 February 2006, 14:21 GMT
This solution inflates the resulting langfile needlessly on most players, and will be even worse as more and more players with different buttons are added. The correct solution is to wait for Langv2 (RSN). Until then, I believe people should just live with the labels being wrong, knowing that they will more than likely be correct once a release is done.

Off topic, could an admin please stop me from having new language-tasks auto-assigned to me, since I'm no longer active?
Comment by Daniel Stenberg (bagder) - Tuesday, 28 February 2006, 14:39 GMT
I don't think you get any tasks assigned anymore since we moved to Flyspray. Do you?
Comment by Jonas Häggqvist (rasher) - Tuesday, 28 February 2006, 14:42 GMT
Ah, My bad. Probably not, no. I just failed to look at the date of this one, since I didn't recognise the title and assumed it was new. Everything's in perfect order then.

Loading...