FS#329 - New puzzle game

Attached to Project: Rockbox
Opened by Anonymous Submitter - Tuesday, 01 October 2002, 17:19 GMT
Last edited by Björn Stenberg (zagor) - Thursday, 09 January 2003, 01:13 GMT
Task Type Patches
Category Games
Status Closed
Assigned To Daniel Stenberg (bagder)
Operating System
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


I wrote a small puzzle game. This is actually a rewrite
of Star, a game written by CDK designed for the hp48

To install it, proceed as follows:
- uncompress the archive patch.tar.gz
- apply the patch patch_fredang.diff
- copy the two files star.c and star.h in the directory
- compile
- copy the file star_levels.txt in the root directory of your

rem : It has some graphical bug on the simulator but not
on the archos.

See you,

Frédéric DANG NGOC
This task depends upon

Closed by  Björn Stenberg (zagor)
Thursday, 09 January 2003, 01:13 GMT
Reason for closing:  
Additional comments about closing:  Logged In: YES

New patch submitted.
Comment by Daniel Stenberg (bagder) - Tuesday, 01 October 2002, 18:23 GMT

I really can't understand the graphical problems in the
simulator. I would *really* like to see this work fine there
too. Have you any clues?

A few comments on the code:

You make lots of assumptions that the font in use is 8
pixels high. Please use the correct function call to check
that out and adjust to at least normally sized fonts.

Don't right-intent without good reason, translators might
need longer wording than the english phrases you use now.

You load the levels into an auto variable on the stack.
Isn't that supposed to be static?

star.c line 502 gives a rightful warning, you declare a
variable 'i' and you use it before you assign a value to it.
Setting it to zero on line 502 seems to work.

star.c line 137 is not a valid prototype, use (void) if no
parameter is wanted.

I like the game! It's kind of relaxed and seems nice enough.
It would be cool to have the game load more levels on demand
if I advance through the first initial ones so that memory
won't be wasted on unplayed levels.
Comment by Frederic DANG NGOC (fredang) - Wednesday, 02 October 2002, 09:52 GMT

Thanks you badger for your remarks and suggestions.
I will take them into account and post a new patch.

For the graphical problem of the simulator, I think I have
found the problem.
In the function lcd_update_rect in the file lcd-x11.c of the
simulator, there are the loop
for(; yline<ymax; yline++) {
I compare with the same function in the file lcd-recorder.c,
and there are a '<=' instead of '<' for the loop.
I replace the '<' by '<=' and it work fine with the simulator.

Comment by Frederic DANG NGOC (fredang) - Monday, 16 December 2002, 16:49 GMT


I have fixed some bugs and modifiy the code to support
languages and font size.

It now loads four levels by four levels in memory in order to
save memory.

Comment by Björn Stenberg (zagor) - Thursday, 09 January 2003, 01:13 GMT

New patch submitted.