Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Settings
  • Assigned To
    zagor
  • Operating System
  • Severity High
  • Priority Medium
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by brking - 2002-10-19
Last edited by zagor - 2003-09-29

FS#452 - .rockbox browsing patch

I wanted to provide a way to make it easier to load
files that reside in .rockbox/. So I put together this
patch. It adds several items to the existing menus
which essentially browse .rockbox/ and filter the
files listed accordingly. For example, I have added a
While Playing menu option to the General Settings which
will open the file browser in the rockbox directory and
only display *.wps files. Selecting one will activate
it, stop will exit back to the menu. I tried to re-use
all the existing file browsing code as I didn't want to
repeat it. I'm sure someone could improve upon this
idea (caching of .rockbox would be a good start) and
come up with a better patch than I have here, but I
wanted to submit some code along with the idea. The
only quirk that I see with the code right now is that
selecting these menus can mess up your actual file
browser cursor - the directory is preserved, but the
file index is not - hopefully someone who knows the
file browsing code better than I can fix this. (I use
the Follow Playlist option, so it isn't really much of
a problem for me)

Closed by  zagor
2003-09-29 21:27
Reason for closing:  Accepted
Additional comments about closing:  

Logged In: YES
user_id=1157

*Finally* committed. Thank you for your amazing patience, Brian.

Attached is an updated version of the patch which fixes the
screen corruption bug in the previous version.

The rockbox_config_browse4.patch fixes all known problems
with this patch and also adds a Playlists menu.

rockbox_config_browse5.patch adds multiple shuffle modes
also. This includes None, All, or Playlist only

Patch 6 properly saves the Playlist only shuffle mode.

Have you any newer patches? I would like to look to add this
to the tree.

Patch 8 applies cleanly to the latest cvs tree.

Ok. The last patch was a bit premature. This one actually
works…

I have been too lazy to go through the code, but it does not
compile under the latest CVS (or last nights for that matter) I
keep getting errors in screens.c

There seems to be a bit of cleanup going on in tree.c which
affects this patch. I'm currently trying to cleanup a
display glitch that has been induced because of this.
Hopefully I will have a fix tomorrow…

Attached is the latest patch. This should apply cleanly to
the current cvs. I verified that it now compiles for the
recorder, which was the problem Eric was having. I only
have the studio model so I was only able to test out the
recorder version using the simulator. Let me know if there
are any problems.

Attached is an updated patch which applies cleanly to the
current cvs.

New patch to stay current with cvs and also move the .cfg
browse menu selection to be under General Settings rather
than Sound Settings now that its use has been expanded.

A new patch to stay current with cvs.

Project Manager
zagor commented on 2003-03-10 15:29

I'm looking to merge this. Could you split the .rockbox browse changes
from the shuffle changes? Thanks.

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.

The attached patch (15) applies to the current cvs.

Another patch to stay current with cvs.

Keeping current with cvs. Patch #17.

After looking at the configurable max files in a directory,
I realized I could easily re-use some of this code to reduce
the memory usage of this patch. So I put a 50 file
limitation on the .rockbox directory. I wasn't sure if this
was sufficient or not, right now it can be changed by
altering a literal in applimits.h. I could make this
configurable as well, but thought that might be overkill.
Patch #18 is attached.

Project Manager
zagor commented on 2003-06-04 12:15

I don't think it's a good idea to use a separate dir buffer for
the .rockbox dir. Yes, you avoid spinning up for rereading the
dir but the added memory consumption and code complexity
isn't worth it, IMHO.

(Sorry for letting this patch drag on for so long…)

Bjorn:
How would you like to see this changed? Would you prefer me
to duplicate the necessary code from dirbrowse?

Here is a new patch (19) which removes the dir buffer for
the .rockbox directory.

Patch 20 is an update against current cvs. It also adds a
plugin browser.

Patch 22 removes the .rockbox playlist browsing function per
Bjorn's request.

Project Manager
zagor commented on 2003-09-29 21:27

*Finally* committed. Thank you for your amazing patience, Brian.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing