Rockbox

Tasklist

FS#452 - .rockbox browsing patch

Attached to Project: Rockbox
Opened by Brian King (brking) - Saturday, 19 October 2002, 02:22 GMT
Last edited by Björn Stenberg (zagor) - Monday, 29 September 2003, 21:27 GMT
Task Type Patches
Category Settings
Status Closed
Assigned To Björn Stenberg (zagor)
Operating System
Severity High
Priority Urgent
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

I wanted to provide a way to make it easier to load
files that reside in .rockbox/. So I put together this
patch. It adds several items to the existing menus
which essentially browse .rockbox/ and filter the
files listed accordingly. For example, I have added a
While Playing menu option to the General Settings which
will open the file browser in the rockbox directory and
only display *.wps files. Selecting one will activate
it, stop will exit back to the menu. I tried to re-use
all the existing file browsing code as I didn't want to
repeat it. I'm sure someone could improve upon this
idea (caching of .rockbox would be a good start) and
come up with a better patch than I have here, but I
wanted to submit some code along with the idea. The
only quirk that I see with the code right now is that
selecting these menus can mess up your actual file
browser cursor - the directory is preserved, but the
file index is not - hopefully someone who knows the
file browsing code better than I can fix this. (I use
the Follow Playlist option, so it isn't really much of
a problem for me)
This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 29 September 2003, 21:27 GMT
Reason for closing:  Accepted
Additional comments about closing:  Logged In: YES
user_id=1157

*Finally* committed. Thank you for your amazing patience, Brian.
Comment by Brian King (brking) - Friday, 13 December 2002, 02:54 GMT

Attached is an updated version of the patch which fixes the
screen corruption bug in the previous version.
Comment by Brian King (brking) - Thursday, 19 December 2002, 01:14 GMT

The rockbox_config_browse4.patch fixes all known problems
with this patch and also adds a Playlists menu.
Comment by Brian King (brking) - Thursday, 19 December 2002, 02:41 GMT

rockbox_config_browse5.patch adds multiple shuffle modes
also. This includes None, All, or Playlist only
Comment by Brian King (brking) - Sunday, 22 December 2002, 23:55 GMT

Patch 6 properly saves the Playlist only shuffle mode.
Comment by Eric Linenberg (elinenbe) - Thursday, 23 January 2003, 21:07 GMT

Have you any newer patches? I would like to look to add this
to the tree.
Comment by Brian King (brking) - Friday, 24 January 2003, 00:25 GMT

Patch 8 applies cleanly to the latest cvs tree.
Comment by Brian King (brking) - Friday, 24 January 2003, 01:53 GMT

Ok. The last patch was a bit premature. This one actually
works...

Comment by Eric Linenberg (elinenbe) - Friday, 24 January 2003, 16:02 GMT

I have been too lazy to go through the code, but it does not
compile under the latest CVS (or last nights for that matter) I
keep getting errors in screens.c
Comment by Brian King (brking) - Saturday, 25 January 2003, 05:02 GMT

There seems to be a bit of cleanup going on in tree.c which
affects this patch. I'm currently trying to cleanup a
display glitch that has been induced because of this.
Hopefully I will have a fix tomorrow...
Comment by Brian King (brking) - Saturday, 25 January 2003, 20:05 GMT

Attached is the latest patch. This should apply cleanly to
the current cvs. I verified that it now compiles for the
recorder, which was the problem Eric was having. I only
have the studio model so I was only able to test out the
recorder version using the simulator. Let me know if there
are any problems.
Comment by Brian King (brking) - Friday, 14 February 2003, 02:22 GMT

Attached is an updated patch which applies cleanly to the
current cvs.
Comment by Brian King (brking) - Saturday, 15 February 2003, 02:19 GMT

New patch to stay current with cvs and also move the .cfg
browse menu selection to be under General Settings rather
than Sound Settings now that its use has been expanded.
Comment by Brian King (brking) - Tuesday, 25 February 2003, 02:32 GMT

A new patch to stay current with cvs.
Comment by Björn Stenberg (zagor) - Monday, 10 March 2003, 15:29 GMT

I'm looking to merge this. Could you split the .rockbox browse changes
from the shuffle changes? Thanks.
Comment by Brian King (brking) - Tuesday, 11 March 2003, 02:26 GMT

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.
Comment by Brian King (brking) - Tuesday, 11 March 2003, 02:29 GMT

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.
Comment by Brian King (brking) - Tuesday, 11 March 2003, 02:30 GMT

Attached is a new patch (14) against the current cvs which
only contains the .rockbox browsing patch. The playlist only
shuffle mode has been removed. I will create another patch
for it.
Comment by Brian King (brking) - Thursday, 20 March 2003, 02:53 GMT

The attached patch (15) applies to the current cvs.
Comment by Brian King (brking) - Thursday, 17 April 2003, 00:49 GMT

Another patch to stay current with cvs.
Comment by Brian King (brking) - Wednesday, 14 May 2003, 00:32 GMT

Keeping current with cvs. Patch #17.
Comment by Brian King (brking) - Wednesday, 14 May 2003, 01:08 GMT

After looking at the configurable max files in a directory,
I realized I could easily re-use some of this code to reduce
the memory usage of this patch. So I put a 50 file
limitation on the .rockbox directory. I wasn't sure if this
was sufficient or not, right now it can be changed by
altering a literal in applimits.h. I could make this
configurable as well, but thought that might be overkill.
Patch #18 is attached.
Comment by Björn Stenberg (zagor) - Wednesday, 04 June 2003, 12:15 GMT

I don't think it's a good idea to use a separate dir buffer for
the .rockbox dir. Yes, you avoid spinning up for rereading the
dir but the added memory consumption and code complexity
isn't worth it, IMHO.

(Sorry for letting this patch drag on for so long...)
Comment by Brian King (brking) - Wednesday, 04 June 2003, 23:38 GMT

Bjorn:
How would you like to see this changed? Would you prefer me
to duplicate the necessary code from dirbrowse?
Comment by Brian King (brking) - Saturday, 07 June 2003, 17:18 GMT

Here is a new patch (19) which removes the dir buffer for
the .rockbox directory.
Comment by Brian King (brking) - Wednesday, 09 July 2003, 02:00 GMT

Patch 20 is an update against current cvs. It also adds a
plugin browser.
Comment by Brian King (brking) - Thursday, 24 July 2003, 00:48 GMT

Patch 22 removes the .rockbox playlist browsing function per
Bjorn's request.
Comment by Björn Stenberg (zagor) - Monday, 29 September 2003, 21:27 GMT

*Finally* committed. Thank you for your amazing patience, Brian.

Loading...