FS#4714 - Preset naming
Attached to Project:
Rockbox
Opened by Anonymous Submitter - Thursday, 23 February 2006, 12:28 GMT
Last edited by Christi Scarborough (christi-s) - Sunday, 19 March 2006, 12:38 GMT
Opened by Anonymous Submitter - Thursday, 23 February 2006, 12:28 GMT
Last edited by Christi Scarborough (christi-s) - Sunday, 19 March 2006, 12:38 GMT
|
DetailsMany bugs together:
The radio seems to overload the processor, and then the selection of letters in the screen is too slow. (not properly a bug) Sometimes, when one direction key is pressed (up, down, right, left), the program keeps repeating this key several times. And sometimes the repetition includes unpressed buttons. When a letter is selected with NAVI, it is sometimes not inserted in the name. The only solution is then to restart the machine. |
This task depends upon
Closed by Björn Stenberg (zagor)
Friday, 24 March 2006, 14:21 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in CVS.
Friday, 24 March 2006, 14:21 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed in CVS.
if you want to fix this your self goto apps/recorder/radio.c and comment out the line cpu_idle_mode(true) (or something similar) in the radio_screen function
there is actually a better way to do it, which is turning idle mode off when a button is pressed and then back on after a timeout with no button being presed but tis a bit more complicated, and not really nescacery
About the solution you comment, I already considered it. This would be preferrable. In fact I am curious because inside the while you can find two if(search_dir) in sequence (is it redundant?). Perhaps the first one sets the radio freq and the second is the one detecting the button pressed. Is it inside the second if where cpu should be set to active? And then, after the switch below, more or less where you can see if (button != BUTTON_NONE) set it to idle mode? Or is it the other way around, idle mode before the switch and idel when button!=BUTTON_NONE? And well, about this timeout, I don't know how to detect it, sorry :(
So, should a patch be added or not? Will you do it along with several other changes?
Just an idea..
It bumps the cpu out of idle if a button is pressed and kicks it down to sleep two seconds after buttonpress again.
~lImbus