- Status Closed
- Percent Complete
- Task Type Patches
- Category Applications
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by Mikael Magnusson - 2006-02-24
Last edited by Teruaki Kawashima - 2010-01-19
Opened by Mikael Magnusson - 2006-02-24
Last edited by Teruaki Kawashima - 2010-01-19
FS#4719 - mandelbrot clear button queue after calculation and keep iter setting after zooming
Currently mandelbrot will keep itself busy for a while if you press zoom too many times, so clear the button queue after finishing a calculation. Also, after zooming the iter variable is reset, which is annoying if you lower it to zoom in somewhere faster.
rockbox-mandelbrot-clear-queu...
(1.1 KiB)
Closed by Teruaki Kawashima
2010-01-19 07:06
Reason for closing: Out of Date
Additional comments about closing:
2010-01-19 07:06
Reason for closing: Out of Date
Additional comments about closing:
superseded by FS#10911 which enables to interrupt
calculation.
i suggest committing. it works well and gevaerts said it can be included but didnt do it because of the 3.1-freeze
This seems like it could be very annoying if you wanted to zoom in 5 levels, and you pressed it five times quickly, but it cleared so you lose some of them. Is it possibly to lose button presses with this patch?
if you want to zoom in 5 levels wouldn't it be better to abort the first 4 calculations (i.e. abort the calculation once the zoom level is changed again) and restart calculating from the top?
yes. if you press the zoom-key one time and then four times while calculating, the four key presses are ignored.
i guess it can be closed. its not wanted and the suggested improvements will be done in a few years or never.
I think it should be committed. Loosing button presses during operations which lead to unresponsiveness isn't annyoing, but safer and should be the common case.
I 100% disagree. I consider being able to queue "zoom" actions a feature and think having to press the button several more times than necessary because it's intentionally ignoring presses a significant problem.
Fix is as bluebrother suggested possibly, but don't ignore button presses. If someone presses zoom 19 times you should be on the 20th level of zoom, not some unpredictable level depending entirely on how quickly/slowly they pressed it.
If you consider it as a problem that you have to wait for all calculations you queued to finish add a dedicated abort button. I still think that zoom levels should be able to get skipped. Dropping the button presses is still the worst solution from my point of view.
i suggest closing, since bluebrother and llorean think its the worst solution…
imo the abort button plus the first suggestion by bluebrother is the best solution.