Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Mikael Magnusson - 2006-02-24
Last edited by Teruaki Kawashima - 2010-01-19

FS#4719 - mandelbrot clear button queue after calculation and keep iter setting after zooming

Currently mandelbrot will keep itself busy for a while if you press zoom too many times, so clear the button queue after finishing a calculation. Also, after zooming the iter variable is reset, which is annoying if you lower it to zoom in somewhere faster.

Closed by  Teruaki Kawashima
2010-01-19 07:06
Reason for closing:  Out of Date
Additional comments about closing:  

superseded by  FS#10911  which enables to interrupt calculation.

Johannes Linke commented on 2008-12-20 11:38

i suggest committing. it works well and gevaerts said it can be included but didnt do it because of the 3.1-freeze

Paul Louden commented on 2009-01-10 16:58

This seems like it could be very annoying if you wanted to zoom in 5 levels, and you pressed it five times quickly, but it cleared so you lose some of them. Is it possibly to lose button presses with this patch?

Dominik Riebeling commented on 2009-01-10 17:08

if you want to zoom in 5 levels wouldn't it be better to abort the first 4 calculations (i.e. abort the calculation once the zoom level is changed again) and restart calculating from the top?

Johannes Linke commented on 2009-01-10 17:12

yes. if you press the zoom-key one time and then four times while calculating, the four key presses are ignored.

i guess it can be closed. its not wanted and the suggested improvements will be done in a few years or never.

Thomas Martitz commented on 2009-02-05 15:24

I think it should be committed. Loosing button presses during operations which lead to unresponsiveness isn't annyoing, but safer and should be the common case.

Paul Louden commented on 2009-02-05 15:31

I 100% disagree. I consider being able to queue "zoom" actions a feature and think having to press the button several more times than necessary because it's intentionally ignoring presses a significant problem.

Fix is as bluebrother suggested possibly, but don't ignore button presses. If someone presses zoom 19 times you should be on the 20th level of zoom, not some unpredictable level depending entirely on how quickly/slowly they pressed it.

Dominik Riebeling commented on 2009-02-14 21:12

If you consider it as a problem that you have to wait for all calculations you queued to finish add a dedicated abort button. I still think that zoom levels should be able to get skipped. Dropping the button presses is still the worst solution from my point of view.

Johannes Linke commented on 2009-02-15 13:45

i suggest closing, since bluebrother and llorean think its the worst solution…

Johannes Linke commented on 2009-02-15 13:48

imo the abort button plus the first suggestion by bluebrother is the best solution.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing