Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface
  • Assigned To No-one
  • Operating System Iriver H100 series
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by roolku - 2006-02-26

FS#4734 - enter key doesn't work in h120 sim windows

This applies to a SDL simulator build of the h120 sim using a fresh cvs checkout.

According to the background image, the enter key on the numeric keypad should act as the stop key. However pressing it does not have an effect. Is the stop button mapped to a different key perhaps?

Closed by  paprica
2006-03-09 16:16
Reason for closing:  Fixed

I just checked the wiki (http://www.rockbox.org/twiki/bin/view/Main/UiSimulator) and the alternative key (a) for the stop button doesn't work either.

I can confirm this.

I checked the sources and found the following:
- the Enter key is only checked on the numeric keypad (SDLK_KP_ENTER, which is somewhat consistent as the numeric keys are also on the keypad). To get the "normal" enter key working SDLK_RETURN needs to be added.
- the alternate key "a" wasn't checked in uisimulator/sdl/buttons.c The attached patch fixes this.

So the documentation is a bit confusing: Keypad Enter or "a". Maybe this should be clarified by splitting the key in a "Keypad" and "alternate" column.

Thank you for the patch - will try it out later. Just to clarify - the enter key on the numpad wasn't working. I think someone mentioned on IRC that SDL treats the enterkey differently - but the the 'a' key will do nicely. :)

I forgot to mention: I'm using Linux, but I think this doesn't make a difference at this point. Tried and found "a" not working on H100 and H300 simulator. Enter wasn't working until I realized I need to enable the numpad (maybe toggling the numpad to numeric mode helps? I'm using a laptop so I can't test non-numeric numpad mode) The Enter key and the keypad's enter are treated differently (SDLK_RETURN vs. SDLK_KP_ENTER) but could be added the same way.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing