FS#4734 - enter key doesn't work in h120 sim windows

Attached to Project: Rockbox
Opened by Robert Kukla (roolku) - Sunday, 26 February 2006, 15:02 GMT
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Operating System Iriver H100 series
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This applies to a SDL simulator build of the h120 sim using a fresh cvs checkout.

According to the background image, the enter key on the numeric keypad should act as the stop key. However pressing it does not have an effect. Is the stop button mapped to a different key perhaps?
This task depends upon

Closed by  Ben Basha (paprica)
Thursday, 09 March 2006, 16:16 GMT
Reason for closing:  Fixed
Comment by Robert Kukla (roolku) - Sunday, 26 February 2006, 17:34 GMT
I just checked the wiki ( and the alternative key (a) for the stop button doesn't work either.
Comment by Dominik Riebeling (bluebrother) - Tuesday, 28 February 2006, 19:46 GMT
I can confirm this.

I checked the sources and found the following:
- the Enter key is only checked on the numeric keypad (SDLK_KP_ENTER, which is somewhat consistent as the numeric keys are also on the keypad). To get the "normal" enter key working SDLK_RETURN needs to be added.
- the alternate key "a" wasn't checked in uisimulator/sdl/buttons.c The attached patch fixes this.

So the documentation is a bit confusing: Keypad Enter or "a". Maybe this should be clarified by splitting the key in a "Keypad" and "alternate" column.
Comment by Robert Kukla (roolku) - Tuesday, 28 February 2006, 19:55 GMT
Thank you for the patch - will try it out later. Just to clarify - the enter key on the numpad wasn't working. I think someone mentioned on IRC that SDL treats the enterkey differently - but the the 'a' key will do nicely. :)
Comment by Dominik Riebeling (bluebrother) - Tuesday, 28 February 2006, 20:12 GMT
I forgot to mention: I'm using Linux, but I think this doesn't make a difference at this point. Tried and found "a" not working on H100 and H300 simulator. Enter wasn't working until I realized I need to enable the numpad (maybe toggling the numpad to numeric mode helps? I'm using a laptop so I can't test non-numeric numpad mode) The Enter key and the keypad's enter are treated differently (SDLK_RETURN vs. SDLK_KP_ENTER) but could be added the same way.