FS#4739 - Bugfix: clear WPS-backdrop when loading new WPS

Attached to Project: Rockbox
Opened by Matthias Mohr (aka Massa) (mmohr) - Monday, 27 February 2006, 01:16 GMT
Last edited by Matthias Mohr (aka Massa) (mmohr) - Friday, 03 March 2006, 18:12 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch hopefully fixes the following bug:
if a WPS with a backdrop has been loaded and
you switch to another WPS without a backdrop,
the old backdrop still gets displayed.

With this patch the settings will be reset
(including the backdrop setting) when loading
a new WPS.

That has technically be done:
A call to wps_clear has been integrated in wps_data_init
(for LCD_BITMAP-targets);
a line to reset the wps-background has been added in wps_reset,
the position of wps_data_init and wps_clear in the file have been interchanged
and wps_data_init will now be called by wps_reset instead of wps_clear.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Saturday, 11 March 2006, 22:08 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks a lot!
Comment by Nicolas Pennequin (nicolas_p) - Monday, 27 February 2006, 20:07 GMT
Good one, thanks a lot :)
I haven't tested it yet, but i will when i have more time.
Maybe you'd also want to look at screens which "forget" to change the backdrop before showing directly after the WPS. The only example i have right now is the ID3 info screen when called directly from the WPS with PLAY + A-B (on H300), but maybe there are others.
Comment by Matthias Mohr (aka Massa) (mmohr) - Monday, 27 February 2006, 21:59 GMT
BTW, with that patch also the album art will get removed
when when changing to a WPS without album art ;)

I'm nearly sure it will have some side effects,
altohugh I couldn't find anything.
But it's too easy - someone else with more rockbox
knowledge should have done this already...
Comment by Matthias Mohr (aka Massa) (mmohr) - Tuesday, 28 February 2006, 07:49 GMT
Now I found a side effect :(
It also clear the WPS backdrop when switching the device off and on again.
And it then doesn't gets reloaded!

So I need to research deeper inside the code - I'll post here if I find something!
Comment by Matthias Mohr (aka Massa) (mmohr) - Tuesday, 28 February 2006, 12:59 GMT
I think I found and fixed the bug.
A new patch can be found below...

(btw, how do I change the details of my patch task here at Flyspray?)
Comment by gl (gl.tter) - Wednesday, 08 March 2006, 11:27 GMT
Hi, I've just stumbled on the same bug after enabling WPS backdrops for the iRiver H1x0's (amongst other WPS goodies, see I'll try out your patch shortly.