Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface → Themes
  • Assigned To No-one
  • Operating System All players
  • Severity Medium
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mmohr - 2006-02-27
Last edited by mmohr - 2006-03-03

FS#4739 - Bugfix: clear WPS-backdrop when loading new WPS

This patch hopefully fixes the following bug:
if a WPS with a backdrop has been loaded and
you switch to another WPS without a backdrop,
the old backdrop still gets displayed.

With this patch the settings will be reset
(including the backdrop setting) when loading
a new WPS.

That has technically be done:
A call to wps_clear has been integrated in wps_data_init
(for LCD_BITMAP-targets);
a line to reset the wps-background has been added in wps_reset,
the position of wps_data_init and wps_clear in the file have been interchanged
and wps_data_init will now be called by wps_reset instead of wps_clear.

Closed by  linusnielsen
2006-03-11 22:08
Reason for closing:  Accepted
Additional comments about closing:  

Thanks a lot!

Good one, thanks a lot :)
I haven't tested it yet, but i will when i have more time.
Maybe you'd also want to look at screens which "forget" to change the backdrop before showing directly after the WPS. The only example i have right now is the ID3 info screen when called directly from the WPS with PLAY + A-B (on H300), but maybe there are others.

mmohr commented on 2006-02-27 21:59

BTW, with that patch also the album art will get removed
when when changing to a WPS without album art ;)

I'm nearly sure it will have some side effects,
altohugh I couldn't find anything.
But it's too easy - someone else with more rockbox
knowledge should have done this already…

mmohr commented on 2006-02-28 07:49

Now I found a side effect :(
It also clear the WPS backdrop when switching the device off and on again.
And it then doesn't gets reloaded!

So I need to research deeper inside the code - I'll post here if I find something!

mmohr commented on 2006-02-28 12:59

I think I found and fixed the bug.
A new patch can be found below…

(btw, how do I change the details of my patch task here at Flyspray?)

Hi, I've just stumbled on the same bug after enabling WPS backdrops for the iRiver H1x0's (amongst other WPS goodies, see http://www.rockbox.org/bugs/task/4802). I'll try out your patch shortly.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing