Rockbox

Tasklist

FS#4759 - search in current playlist

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Wednesday, 01 March 2006, 12:26 GMT
Task Type Patches
Category Playlists
Status Closed
Assigned To Tomas (Tomas)
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

this patch adds the ability to search for a string (not case sensitive) in all the tracks in the current playlist, and lets you choose to jump to one of those tracks if u want to...
the menu is with "view current playlist" and "save current playlist"
This task depends upon

Closed by  Tomas (Tomas)
Saturday, 04 March 2006, 23:53 GMT
Reason for closing:  Accepted
Additional comments about closing:  In CVS now.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 01 March 2006, 12:33 GMT
sorry.. im a dill
ignoerr the first file
Comment by Jonathan Gordon (jdgordon) - Wednesday, 01 March 2006, 12:35 GMT
me is a real idiot.... not just a pretend 1...
3rd time lucky
Comment by Jonathan Gordon (jdgordon) - Wednesday, 01 March 2006, 12:37 GMT
ok, u know what?? just ban me from patch submition
Comment by Jonathan Gordon (jdgordon) - Wednesday, 01 March 2006, 12:39 GMT
FUCK!
Comment by Daniel Stenberg (bagder) - Wednesday, 01 March 2006, 13:20 GMT
You tried searching for a string that occurs in more than 200 titles? It'll overflow the result array.

Also, you could consider doing something faster than strcasestr() at least when you search for somewhat longer strings. Boyer-Moore is likely to make a significant difference already at perhaps 6-8 letter search strings.
Comment by Jonathan Gordon (jdgordon) - Thursday, 02 March 2006, 06:26 GMT
"You tried searching for a string that occurs in more than 200 titles? It'll overflow the result array."
woops... i added the check, but then redid the search coz i changed part of it and forgot to put it back in.. its there now..

"Also, you could consider doing something faster than strcasestr()"
i did a search for a 10 letter string on my entire mp3 collection (~2700 files) and it took 3 seconds... thats fast enough i think...

also, ive added a splash msg if no matches are found.

lastly, sorry for all the above comments... i obviously was too tired to be coding last night (1:30pm is 12:30am for me)
Comment by Jonathan Gordon (jdgordon) - Thursday, 02 March 2006, 10:06 GMT
okey dokey.. hopefully this is it...
changes:
not hardcoding the kbd_input array size in that call, added a progress splash, press OFF to kill the search, turn the bl on when the search is finished, some other minor things ive forgotten
Comment by Tomas (Tomas) - Saturday, 04 March 2006, 15:10 GMT
Assigned to myself, just a few last questions to answere (see dev-mailinglist). I can commit it for you.

Loading...