Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Playlists
  • Assigned To
    Tomas
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2006-03-01

FS#4759 - search in current playlist

this patch adds the ability to search for a string (not case sensitive) in all the tracks in the current playlist, and lets you choose to jump to one of those tracks if u want to… the menu is with "view current playlist" and "save current playlist"

Closed by  Tomas
2006-03-04 23:53
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

In CVS now.

jdgordon commented on 2006-03-01 12:33

sorry.. im a dill
ignoerr the first file

jdgordon commented on 2006-03-01 12:35

me is a real idiot…. not just a pretend 1… 3rd time lucky

jdgordon commented on 2006-03-01 12:37

ok, u know what?? just ban me from patch submition

Project Manager
bagder commented on 2006-03-01 13:20

You tried searching for a string that occurs in more than 200 titles? It'll overflow the result array.

Also, you could consider doing something faster than strcasestr() at least when you search for somewhat longer strings. Boyer-Moore is likely to make a significant difference already at perhaps 6-8 letter search strings.

jdgordon commented on 2006-03-02 06:26

"You tried searching for a string that occurs in more than 200 titles? It'll overflow the result array."
woops… i added the check, but then redid the search coz i changed part of it and forgot to put it back in.. its there now..

"Also, you could consider doing something faster than strcasestr()"
i did a search for a 10 letter string on my entire mp3 collection (~2700 files) and it took 3 seconds… thats fast enough i think…

also, ive added a splash msg if no matches are found.

lastly, sorry for all the above comments… i obviously was too tired to be coding last night (1:30pm is 12:30am for me)

(application/octet-stream)    search_in_pl.patch (5.3 KiB)
jdgordon commented on 2006-03-02 10:06

okey dokey.. hopefully this is it… changes:
not hardcoding the kbd_input array size in that call, added a progress splash, press OFF to kill the search, turn the bl on when the search is finished, some other minor things ive forgotten

(application/octet-stream)    search_in_pl.patch (5.6 KiB)
Tomas commented on 2006-03-04 15:10

Assigned to myself, just a few last questions to answere (see dev-mailinglist). I can commit it for you.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing