• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Battery/Charging
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Anonymous Submitter - 2006-03-05
Last edited by petur - 2007-08-02

FS#4774 - Extends SPDIF Enable option for Battery / Charger.

(against today’s CVS).

This patch extends the “Optical Output” option on HAVE_SPDIF_POWER/HAVE_CHARGING platforms (iRivers) from “OFF/ON” to “OFF/Battery Only/Plugged Only/Battery & Plugged”. SPDIF switching is then done automatically based on power status changes.

This is useful eg. when always using the optical out at home, but not wanting to draw unnecessary battery power on the move.

It also auto-disables it when USB is connected, and refreshes on disconnection.

The changes only affect HAVE_SPDIF_POWER/HAVE_CHARGING platforms (CONFIG_BLOCK_VERSION is bumped, so write a .cfg file before running).

Seems solid, no known issues.
– gl.tter (gl.tter [AT] r-i-l [DOT] net)

Closed by  petur
2007-08-02 21:13
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

real name policy!

Here’s the patch.

(note I created the task before signing up - hope this doesn’t cause any problems).


Available keyboard shortcuts


Task Details

Task Editing