FS#4796 : Display current dir while browsing files

Status Closed
Percent Complete
100%
Task Type Patches
Category
Assigned To No-one
Operating System All players
Severity Low
Priority Very Low
Reported Version
Due in Version Undecided
Due Date Undecided
Votes
Private

Attached to Project: Rockbox
Opened by lowlight - 2006-03-07

FS#4796 - Display current dir while browsing files

This patch adds “titles” to the gui list widget. It allows for setting a title/icon to display at the top of the list.

Currently, I’m using this feature to show the current directory (except the root dir) while browsing files. See http://forums.rockbox.org/index.php?topic=2876.0 for an example. To enable this, there’s a menu option in General Settings → File View → Show Current Dir.

Note: Scrolling the title was a problem because line scrolling depends on the screen xmargin which needs to be different for the title line versus the rest of the items. I’ve included a work around for ONLY the H100 (lcd-h100.c and lcd-h100-remote.c) and I haven’t observed any fowl behavior. The changes should be the same for the other lcd files.

If this patch is accepted (or if there is interest), I can try to extend this concept to it to the menu system as well, i.e. to display the current menu.

list_titles.patch (14.8 KiB)

Closed by safetydan
2006-08-16 04:22
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

I\'m sorry that we missed this patch when http://www.rockbox.org/tr acker/task/5795 got comitted. I\'ll close it now since it is out of date with the functionality in CVS.

Comments (8)
Related Tasks (0/0)

bk commented on 2006-03-07 19:33

Works well! I think it’s a great idea to implement this for menus as well (they both use the list widget, so it shouldn’t be too hard to do).

Is it possible to highlight the title somehow? Display it in inverse or underline?

Shouldn’t the root dir have a title too? “/” ? If menus have titles this will be less of an issue.

nicolas_p commented on 2006-03-16 17:22

I made a version of this patch which will apply and compile cleanly against paprica’s scroll margins patch (which can be found here : http://www.rockbox.org/tracker/task/2994 )
Use -p0 to apply

list_titles_scrollmargins.pat... (16.3 KiB)

lowlight commented on 2006-03-21 21:33

UPDATE: 2006-03-21
Synced to current cvs.

list_titles.patch (14.8 KiB)

nicolas_p commented on 2006-03-22 13:04

Your sync was broken by a commit which changed english.lang.
I resynched it with the current CVS (2006.03.22), and made a version which will apply cleanly against the scroll margins patch

BTW: I love your patch :) I hope it’ll get included in CVS soon…

list_titles.patch (16.3 KiB)

list_titles_scrollmargins.pat... (16.3 KiB)

carmenm commented on 2006-03-24 08:58

Would it be possible not to display it on the remote because we already dont have a lot of lines displayed, so one less is quite annoying ;)

nicolas_p commented on 2006-04-04 16:22

upadated for current CVS

nicolas_p commented on 2006-04-04 21:18

fixed a small mistake in the previous patch and added a version which will apply and compile cleanly against the scroll margins patch.

list_titles.patch (16.4 KiB)

list_titles_scrollmargins.pat... (16.4 KiB)

Rayyan Fairaq commented on 2006-06-23 16:58