Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lostlogic - 2006-03-10

FS#4811 - RFC: Basic wheel acceleration

This is a _very_ quick whack at offering acceleration on the iPod 5g button click wheel.

* Does this feel better to people?
* What improvements should be made before we adopt something like this?
* I also move the queue empty check out a bit to save some interrupt time when we’re just going to throw away the calculations any way.

   acceleration.patch (4.6 KiB)
Closed by  lostlogic
2006-03-18 21:18
Reason for closing:  Rejected
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Ferget this patch for now, the wheel\'s fine as it is now in CVS pending real acceleration.

lostlogic commented on 2006-03-10 05:06

Updated patch, much less sucking occurs.

   acceleration.patch (9.2 KiB)
darkkone commented on 2006-03-10 09:24

After trying the “much less sucking” version, I have to say I like it. Overall the UI feels *much* more responsive. Since the queue empty check was added, sometimes I’d have problems getting the volume to change (specifically when the CPU was at 30mhz, I’m also using the cpu-boost enabling patch. The backlight just wouldn’t come on.)

So, simply put, “I like it.” The UI feels much more responsive to me, in general, with it.

lostlogic commented on 2006-03-10 13:00

Updated to apply against my recent code policing

   acceleration.patch (6.4 KiB)
herz42 commented on 2006-03-12 15:45

I also like the patch.
Although turning the wheel (I think also without the patch) seems to consume much processing power and prevents the pcm buffer filling to keep up.

Here is a patch for the patch to further slow it down :)
It implements the BUTTON_REPEAT feature that will prevent wrapping at the beginning/end of a list while in a fast scroll action.

Therefore it sets the BUTTON_REPEAT flag if the scroll wheel was active in the last HZ/5.
It doesn’t care about scroll directions. But I think that is no problem in this case.

(application/octet-stream)    button_repeat.patch (2 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing