Rockbox

  • Status Closed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by bot47 - 2006-03-14

FS#4832 - Xobox Improvements

Some Xobox improvements. Better iPod key assigments, a small cheat and a more friendly loading screen.

Closed by  mikaelh
2007-01-29 19:25
Reason for closing:  Out of Date
Additional comments about closing:  

Didn\'t get a fixed version for a year, feel free to resubmit an updated version according to comments and reopen.

Generally speaking, many plugins use Menu+Select to quit. It’s kinda the accepted combination.

bot47 commented on 2006-03-14 14:14

I know, but this app is an exception. The current quit combination realy hurts the gameplay.

Since the select button isn’t used in gameplay, just to pause, I’m curious how it hurts it?

bot47 commented on 2006-03-14 14:21

You have to control the position of the worm realy fast. It often happens that you hit action + menu accidetaly at the same time if you just want to make the worm go upwards. That’s it.

So, what’s the different with SELECT | PLAY then? I mean, are you just less likely to press it when moving down?

bot47 commented on 2006-03-14 14:25

Just try it and you WILL notice that my correction is senseful.

Except I’ve played the game quite a bit, and have never accidentally hit menu. So, please refrain from telling me I will do something that it is evident I haven’t. Since you can move up from the bottom, or down from the top, and since menu is equidistant from select compared to play, what benefit is gained by simply putting the option on the opposite side of the pad?

I also don’t understand why MENU+PLAY is any different to MENU+SELECT. It’s never given me problems on either my 5g iPod, or my 4g Color.

Other comments about your patch:

a) Don’t comment out code - remove it.
b) Don’t use TABs (see docs/CONTRIBUTING in cvs)
c) A key combination for CHEAT needs to be defined for all keypad types, not just the iPod.
d) LCD_RGBPACK is only defined for targets with colour LCDs (see firmware/export/lcd.h)

It’s always helpful to test-compile patches for a variety of Rockbox targets - at a minimum, one Archos device, one iriver and one iPod, but preferably more.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing