FS#4843 - Bugfix: ID3 info screen (from WPS) backdrop & statusbar

Attached to Project: Rockbox
Opened by Nicolas Pennequin (nicolas_p) - Friday, 17 March 2006, 16:33 GMT
Last edited by Nicolas Pennequin (nicolas_p) - Sunday, 19 March 2006, 19:41 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This fixes a very annoying bug : the WPS backdrop was displayed in the ID3 info screen when it was called directly from the WPS with the shortcut (PLAY + A-B on H300).
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Tuesday, 21 March 2006, 11:32 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 19 March 2006, 19:35 GMT
new patch to fix another bug, related to the satusbar in the ID3 info screen. If the WPS disabled the statusbar when it was enabled in the global settings, the ID3 info screen would be displayed with an incorrect y margin.
Comment by Nicolas Pennequin (nicolas_p) - Sunday, 19 March 2006, 20:02 GMT
Oops, the patch above set an incorrect y margin for WPSs without the statusbar. It's fixed now
Comment by Linus Nielsen Feltzing (linusnielsen) - Monday, 20 March 2006, 08:44 GMT
In Rockbox, the general policy is that the caller is responsible for restoring the margins after calling a screen or menu function. Therefore I suggest this patch instead.
Comment by Nicolas Pennequin (nicolas_p) - Tuesday, 21 March 2006, 10:27 GMT
Thanks for having a look at it, Linus :)
Your patch works fine for me, i suggest committing it to CVS.