• Status Closed
  • Percent Complete
  • Task Type Patches
  • Category Drivers
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Hristo Kovachev - 2006-03-20

FS#4867 - Reworked button.h

This is a rework of button.h :
1) Main unit’s buttons are put from the LSB to the MSB
2) Remote control’s buttons are starting from 20th bit (zero based) downwards
3) Removed the BUTTON_REMOTE modifier, changed with a bitmask of all of the remote buttons (where applicable, otherwise with 0)
4) Added a complementary BUTTON_MAIN bitmask

The free bits currently on all targets are (at least) 21-23,26, and BUTTON_REPEAT is bit 24, BUTTON_REL - 25

In fact it’s possible to SHR remote buttons one bit more, but i left one reserved bit between the remote and main buttons on the target with most keys currently - iriver Hxxx

Please, try it on
1) Archos Ondio, Recorder (it doesn’t matter which one) & Player (doesn’t matter also)
2) iPod 3g, iPod4g

if there are bugs, comment them here

10q in advance

Closed by  Hristo Kovachev
2006-03-21 10:02
Reason for closing:  Accepted


Available keyboard shortcuts


Task Details

Task Editing