Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Remote
  • Assigned To
    Hristo Kovachev
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by David Rothenberger - 2006-03-24

FS#4913 - make backlight on first keypress work with LCD remote

This updates patch 2920 (http://www.rockbox.org/tracker/task/2920) to work with remotes. 2920 added an option to have the first keypress only turn on the backlight when the backlight was off. The problem is that it doesn’t consider the source of the keypress or the state of the remote backlight. So, it filtered the first keypress from the remote if the main unit’s backlight was off, even if the remote’s backlight was on. It would also fail to filter a keypress from the remote when the remote’s backlight was off but the main unit’s backlight was on.

This patch adds another parallel option to settings for the remote. It filters the first keypress from the remote only if the remote’s backlight is off and the first keypress from the main unit only if the main unit’s backlight is off.

Closed by  Hristo Kovachev
2006-03-25 19:17
Reason for closing:  Accepted
David Rothenberger commented on 2006-03-24 22:34

Update the patch to add a stub so the bootloader builds.

David Rothenberger commented on 2006-03-25 04:52

Just wanted to clarify that without this patch, the remote no longer works with the existing “first keypress only turns on backlight” option enabled. The remote button presses are filtered because the main unit’s LCD backlight is off, but remote button keypresses don’t turn the main unit’s LCD backlight on, so the remote button presses are always filtered out.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing