Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category User Interface
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by paulheu - 2006-04-01
Last edited by jdgordon - 2007-07-31

FS#4988 - Optionally keep backlight on while plugins are running

This patch will add an option to General settings/Display/LCD settings to keep backlight on when using plugins

My first patch, so be gentle.. :)

Closed by  jdgordon
2007-07-31 12:54
Reason for closing:  Rejected
Additional comments about closing:  

This idea was commited a while ago, but immediatly reverted because it was decided it wasnt worth the bin size cost

small change

moved setting save to end of block (as suggested..)

Ahum.. one should check a patch before uploading.. Revious one works, but needed -p1 ..

This one’s tested and requires no ‘special tricks..’ :)

mmohr commented on 2006-04-06 07:55

Good
I think each plugin should decide itself if it should allow to switch off the backlight or
does absolutely make no sense for game plugins to switch off the
e.g. for encoding or battery testing it does absolutely make sense!

So I suggest, to add a API function with which the plugins could decide theirselve if the
be switched off or not.

Nevertheless I resynched your patch with the current CVS (langv2 changes)...

Actually this exists in the current API (backlight_on, backlight_off and backlight_set_timeout) but is never used it seems..

I just like the option to keep backlight on for plugins.. If it never makes it into CVS I’ll stil use it, unless plugin writers start using the available options.. :^)

mmohr commented on 2006-04-07 11:59

As far as I know backlight_on switches the backlight on (for the
switches it
backlight_set_timeout changes the timeout for switching the backlight automatically
me if I’m wrong)

That’s not exactly what I
thought about an easy function, with which the plugin can either
ever switch the backlight off as long as I
“use the normal backlight settings”
“use my special timeout”

That’s all - and this should then automatically be used as long as the plugin
resets to normal behaviour when the plugin
further function call of the plugin itself).

BTW, grep at the plugin directory you’ll find some
backlight_off calls ;)

Updated patch to prevent double patches in language file.

I would like to see this in CVS.. but if not Oh well.. ;^)

Requires updating for SVN

It’s really not that hard to do..

Sorry I don’t know how to, I wish I knew... I’ll try learning myself

Great patch works on 5.5G iPod 30GB. One suggestion: changes the options to On and Off to keep it consistent with the other backlight settings. Not sure if this is causing Doom to turn off the backlight in game though

Tested on:

5.5G
iPod
iPod
iPod Nano

Also tested on 4G Grayscale. SVN ready me thinks

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing