FS#5013 - Fwpatcher fix spurious patching attempts

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Monday, 03 April 2006, 16:13 GMT
Last edited by Jonas Häggqvist (rasher) - Thursday, 18 May 2006, 22:28 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity High
Priority Immediate
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch fixes the problem with fwpatcher that meant it'd attempt to patch all the time. The problem was that the commandline driven interface used WM_USER as signal to start patching. This signal is reserved and will be generated for a lot of different commands. The solution is to use something in the range 0xC000-0xFFFF which is available for applications as signal instead as per

Patch severity set to High because without it, keyboard navigation is completely impossible Priority immediate because I don't think 3.0 should be allowed to ship with an fwpatcher that is not accessible (that is of course if fwpatcher is to be used for 3.0).
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Tuesday, 20 June 2006, 11:01 GMT
Reason for closing:  Accepted
Additional comments about closing:  Alright, all\'s fine then. I was just a little curious why the fwpatcher had not been updated to include the fix and thought you might have forgot.
Comment by Jonas Häggqvist (rasher) - Monday, 03 April 2006, 16:31 GMT
Ooops, read that wrong. The correct range is 0x8000 - 0xBFFF. Fixed patch attached.
Comment by Jonas Häggqvist (rasher) - Thursday, 18 May 2006, 22:29 GMT
Just making some noise, since the distributed fwpatcher in the wiki has not been updated to include this fix.

IMHO, this must be done for 3.0.
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 20 June 2006, 10:57 GMT
Yes, the bootloader must be updated anyway so these fixes will be included, as they are in CVS already.