Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Recording
  • Assigned To No-one
  • Operating System Another
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by vinylivo - 2006-04-04
Last edited by petur - 2010-03-03

FS#5021 - Recording Histogram

So here is a separated patch (from the agc_enhance_pack) for recording histogram, battery remain time and disk space.

It shows a graph of peak levels over time. A balance meter shows the actual stereo image position. The battery remain time and remaining disk space are shown in graphic and numeric values too.
Use -p1 for patching.

(application/octet-stream)    rec_histogram_1.patch (23.8 KiB)
Closed by  petur
2010-03-03 22:17
Reason for closing:  Accepted
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

histogram accepted, balance, disk and battery parts not taken

vinylivo commented on 2006-04-09 17:59

updated for new language format and added coulour support for histogramm.

see AGC patch http://www.rockbox.org/tracker/task/4748 for a version with AGC and Histogram feature because it’s not so easy to apply both patches seperate.

this patch was done to daily-2006-04-08 and u need -p1 option for patching.

(application/octet-stream)    rec_histogram_2.patch (29.2 KiB)
paulheu commented on 2006-06-18 12:00

Anyone heard anything from vinylIvo recently? I’d like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..

paulheu commented on 2006-08-22 15:05

I synced the histogram patch against current CVS (060822). As far as I can see it works fine..

   histogram_PH.diff (25.5 KiB)
paulheu commented on 2006-08-22 18:17

Using the patch together with the Peakmeter margin and heights patch (http://www.rockbox.org/tracker/task/4871) does not work.. so some works needs to be done there..

mmmm- commented on 2006-08-23 10:41

Just because one patch isn’t compatible with another doesn’t mean that work needs to be done.
Work only needs doing if either patch isn’t compatible with CVS.
If one of them got committed, then work would need to be done on the other to make them compatible.

rasher commented on 2006-08-23 11:31

In fact, patches should not be adapted to work with other patches, as this makes them harder to test and incorporate into CVS. As Martin said, the only thing that matters is that the patch applies against CVS.

paulheu commented on 2006-08-23 11:46

I know and understand, it was ‘just’ a remark..;) As far as I can see the histogram patch I synced works fine against current CVS..

so there! B)

petur commented on 2007-08-03 20:53

*marker* part of REP

isanggon commented on 2008-07-24 02:11

re-synced incompletely. Almost successful, but histogram printed wrong position. My lack of understanding this patch, I cound not completed this patch. I attach patch files here. Is any one can complete this, please help. I think there remains small, but big step.

I didn’t worked saparetely with contdown patch. Attached patch is histogram patch + countdown patch.
When apply these patch, rec_button patch first. rec_button was done by kugel, but you should fix for hxxx series. you can easily fix keymap file, compare with attached keymap file.

rec button patch is here.
http://www.rockbox.org/tracker/task/5555#comment8661

   _rep_except_rec-button_patch_... (308 KiB)
   keymap-h1x0_h3x0.c (56.1 KiB)
isanggon commented on 2008-07-24 06:23

Now, solved histogram positon problem. This problem was related with statusbar issue.
Remaining works is two.

1. remove last blank line upper of histogram
2. filename printing issue : when goes in recording, filename is missing.

   _rep_except_rec-button_patch_... (311.5 KiB)
petur commented on 2008-10-19 21:14

I’m looking at getting the remainders of the REP. Your updated patch contains two files that do not belong there and I think some other stuff that was already committed. I’m basing my work on an earlier patch, unless you tell me you fixed some bugs in there…

petur commented on 2010-02-11 23:20

YAY… histogram patch - next generation.
This patch does histogram only, no battery, diskspace or balance

Only tested briefly on h300

   histo_NG_1.patch (20.4 KiB)
petur commented on 2010-02-13 00:22

Also (briefly) tested on h1x0, enabled for h1x0 and a small cosmetic fix

   histo_NG_2.patch (20.5 KiB)
jdgordon commented on 2010-02-13 00:37

can you please change it so its drawn like a widget or something our of recording.c? move all its logic out into apps/histogram.c or something? if it uses the peak values does that mean it could be used on the wps also?

please please please just change (at least) the drawing code to just draw the historgram in a given viewport on the screen.

petur commented on 2010-02-19 23:45

code cleanup

   histo_NG_3.patch (18.5 KiB)
petur commented on 2010-03-01 23:41

code cleanup, RC

   histo_NG_4.patch (19.1 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing