Rockbox

updated for new language format and added coulour support for histogramm.

see AGC patch http://www.rockbox.org/tracker/task/4748 for a version with AGC and Histogram feature because it’s not so easy to apply both patches seperate.

this patch was done to daily-2006-04-08 and u need -p1 option for patching.

   rec_histogram_2.patch (29.2 KiB)

Anyone heard anything from vinylIvo recently? I’d like to see and update to the histogram patch to go with the current AGC build.. I kinda miss the pretty pictures..

I synced the histogram patch against current CVS (060822). As far as I can see it works fine..

   histogram_PH.diff (25.5 KiB)

Using the patch together with the Peakmeter margin and heights patch (http://www.rockbox.org/tracker/task/4871) does not work.. so some works needs to be done there..

Just because one patch isn’t compatible with another doesn’t mean that work needs to be done.
Work only needs doing if either patch isn’t compatible with CVS.
If one of them got committed, then work would need to be done on the other to make them compatible.

In fact, patches should not be adapted to work with other patches, as this makes them harder to test and incorporate into CVS. As Martin said, the only thing that matters is that the patch applies against CVS.

I know and understand, it was ‘just’ a remark..;) As far as I can see the histogram patch I synced works fine against current CVS..

so there! B)

*marker* part of REP

re-synced incompletely. Almost successful, but histogram printed wrong position. My lack of understanding this patch, I cound not completed this patch. I attach patch files here. Is any one can complete this, please help. I think there remains small, but big step.

I didn’t worked saparetely with contdown patch. Attached patch is histogram patch + countdown patch.
When apply these patch, rec_button patch first. rec_button was done by kugel, but you should fix for hxxx series. you can easily fix keymap file, compare with attached keymap file.

rec button patch is here.
http://www.rockbox.org/tracker/task/5555#comment8661

   _rep_except_rec-button_patch_... (308 KiB)
   keymap-h1x0_h3x0.c (56.1 KiB)

Now, solved histogram positon problem. This problem was related with statusbar issue.
Remaining works is two.

1. remove last blank line upper of histogram
2. filename printing issue : when goes in recording, filename is missing.

   _rep_except_rec-button_patch_... (311.5 KiB)

I’m looking at getting the remainders of the REP. Your updated patch contains two files that do not belong there and I think some other stuff that was already committed. I’m basing my work on an earlier patch, unless you tell me you fixed some bugs in there…

YAY… histogram patch - next generation.
This patch does histogram only, no battery, diskspace or balance

Only tested briefly on h300

   histo_NG_1.patch (20.4 KiB)

Also (briefly) tested on h1x0, enabled for h1x0 and a small cosmetic fix

   histo_NG_2.patch (20.5 KiB)

can you please change it so its drawn like a widget or something our of recording.c? move all its logic out into apps/histogram.c or something? if it uses the peak values does that mean it could be used on the wps also?

please please please just change (at least) the drawing code to just draw the historgram in a given viewport on the screen.

code cleanup

   histo_NG_3.patch (18.5 KiB)

code cleanup, RC

   histo_NG_4.patch (19.1 KiB)