Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Plugins
  • Assigned To No-one
  • Operating System iPod 5G
  • Severity Low
  • Priority Very Low
  • Reported Version
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Suntiger - 2006-04-07
Last edited by petur - 2006-05-01

FS#5061 - JPEG viewer - next image when zoomed in does not work

Oddly enough, after the inclusion of the JPEG viewer menu patch in CVS, the buttons in the JPEG viewer which were previously used to move to the next and previous images no longer work. (on iPods, this was select+right/left).

They’re still defined in the code: (JPEG_PREVIOUS and JPEG_NEXT)

#elif (CONFIG_KEYPAD == IPOD_3G_PAD) || (CONFIG_KEYPAD == IPOD_4G_PAD)
#define JPEG_ZOOM_IN BUTTON_SCROLL_FWD
#define JPEG_ZOOM_OUT BUTTON_SCROLL_BACK
#define JPEG_UP BUTTON_MENU
#define JPEG_DOWN BUTTON_PLAY
#define JPEG_LEFT BUTTON_LEFT
#define JPEG_RIGHT BUTTON_RIGHT
#define JPEG_MENU (BUTTON_SELECT | BUTTON_MENU)
#define JPEG_NEXT_PRE (BUTTON_SELECT | BUTTON_RIGHT)
#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REL)
#define JPEG_TOGGLE_SLIDESHOW (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REPEAT)
#define JPEG_PREVIOUS (BUTTON_SELECT |BUTTON_LEFT)

but when pressed, nothing happens.

Moving to next or previous works fine when zoomed out.

The task depends upon
ID Project Summary Priority Severity Assigned To Progress
5362 Rockbox  FS#5362 - Bugfix #5159 & #5061 & voice clip bug (jpeg.c)  Very Low Low bger
100%
Closed by  linuxstb
2006-05-20 13:48
Reason for closing:  Fixed
Additional comments about closing:  

Fixed in CVS

Damn, category again… should be "plugins"

Replacing the above with the following code fixes the issue:

#elif (CONFIG_KEYPAD == IPOD_3G_PAD) || (CONFIG_KEYPAD == IPOD_4G_PAD)
#define JPEG_ZOOM_IN BUTTON_SCROLL_FWD
#define JPEG_ZOOM_OUT BUTTON_SCROLL_BACK
#define JPEG_UP BUTTON_MENU
#define JPEG_DOWN BUTTON_PLAY
#define JPEG_LEFT BUTTON_LEFT
#define JPEG_RIGHT BUTTON_RIGHT
#define JPEG_MENU (BUTTON_SELECT | BUTTON_MENU)
#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT)
/*#define JPEG_NEXT (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REL)*/
#define JPEG_TOGGLE_SLIDESHOW (BUTTON_SELECT | BUTTON_RIGHT | BUTTON_REPEAT)
#define JPEG_PREVIOUS (BUTTON_SELECT | BUTTON_LEFT)

Look at patch #5362

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing